#9227 Refactor useTheme to use useManagedStorageState
#9228
Conversation
…b.com/pixiebrix/pixiebrix-extension into feature/9222_hide_sidebar_logo_policy merge origin
|
Just calling out that I'd like clarification on
|
| useAsyncExternalStore(themeStorageSubscribe, themeStorage.get); | ||
|
|
||
| const { data: managedStorageState, isLoading: isManagedStorageLoading } = | ||
| useManagedStorageState(); |
There was a problem hiding this comment.
Let's use this as an opportunity to properly refactor useManagedStorageState to return AsyncState
There was a problem hiding this comment.
This should probably use the following? I don't remember if there's a reason why we didn't use that other than that maybe the useAsyncExternalStore method didn't exist yet (I haven't checked) / or it just wasn't very valuable given that managed storage values should never change in practice:
useAsyncExternalStorereadManagedStorage
I think we then get error handling for free with those
There was a problem hiding this comment.
I was wondering the same thing, re why not use readManagedStorage + useAsyncExternalStore
There was a problem hiding this comment.
I was wondering the same thing, re why not use readManagedStorage + useAsyncExternalStore
I don't see a reason not to. The main difference will be it will be technically possible for the hook to return an error state. Whereas the current one could potentially stay isLoading indefinitely. But I don't think the difference matters in practice
| @@ -57,7 +59,7 @@ beforeEach(() => { | |||
| useManagedStorageStateMock.mockReturnValue({ | |||
There was a problem hiding this comment.
NIT: use valueToAsyncState from asyncStateUtils
| jest.mocked(themeStorage.get).mockResolvedValue({ | ||
| ...customTheme, | ||
| showSidebarLogo: themeValue, | ||
| lastFetched: Date.now(), |
There was a problem hiding this comment.
NIT: save the time and use it to validate against:
| jest.mocked(themeStorage.get).mockResolvedValue({ | |
| ...customTheme, | |
| showSidebarLogo: themeValue, | |
| lastFetched: Date.now(), | |
| const lastFetched = Date.now(); | |
| jest.mocked(themeStorage.get).mockResolvedValue({ | |
| ...customTheme, | |
| showSidebarLogo: themeValue, | |
| lastFetched, |
|
|
||
| expect(result.current.activeTheme).toMatchObject({ | ||
| ...customTheme, | ||
| lastFetched: expect.any(Number), |
There was a problem hiding this comment.
| lastFetched: expect.any(Number), | |
| lastFetched, |
# Conflicts: # src/hooks/useTheme.test.ts # src/hooks/useTheme.ts
Playwright test results
Details
Flaky testschrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod Skipped testschrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor |
What does this PR do?
Discussion
useManagedStorageStatehook throws on error, causing the unit test"uses activeTheme when error occurs in managed storage"to fail. Do we want to add error-handling touseManagedStorageStateto preserve this behavior in the sidebar?