Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: rewrite assetpack #69

Merged
merged 10 commits into from
Jul 17, 2024
Merged

breaking: rewrite assetpack #69

merged 10 commits into from
Jul 17, 2024

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jul 3, 2024

This PR is a complete overhaul of AssetPack to simplify its design and provide some new powerful features

  • Caching now works! AssetPack will only transform an asset when it changes
  • Supports multipacked spritesheets
  • Supports compressing spritesheets and atlas files to webp/avif
  • Added cache busting strings to filenames
  • A complete set of docs with examples for how to set up the project
    https://pixijs.io/assetpack/
  • Remove monorepo design, you now only need to install @assetpack/core

github-actions[bot]

This comment was marked as resolved.

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, this is all good! As we have had heavy reviews on this internally as we developer it.

Docs wise. Here is my feedback:

  • lets put the examples at the top of each page, above the API!
  • A configurable asset pipeline for web games -> A configurable asset pipeline for the web

image

  • i wander if we remove the cahce-busting in the result image? Might make it easier to understand! ]

image,

  • for the manifest section, lets so the manifest thats generated. I think its worth showing some code on how this can be used in Pixi too via Assets!

Great work man!

@Zyie Zyie marked this pull request as ready for review July 8, 2024 13:30
@Zyie Zyie merged commit 0734d02 into main Jul 17, 2024
8 checks passed
@Zyie Zyie deleted the dev branch July 17, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants