This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
Fix dark color not premultiplied by world alpha #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally found the time to test the dark tint batcher, and it works great!
This PR just fixes a small issue with dark color and PMA.
Dark color in Spine has just RGB and no alpha. However, since in Pixi we expect colors to be premultiplied, we need to premultiply the dark color by the world alpha (which is the alpha resulting from the parent and normal color alpha).
You can test the difference using these skeletons:
Here are two screenshots at 10% of the animation time of the Coin example.
Before fix:
After fix: