Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alias): Send nil when alias is removed #67

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

pjechris
Copy link
Owner

⚽️ Description

When calling one of the method removing an alias, the observers were notified of such thing. Now send nil when alias is removed.

🔨 Implementation details

The implementation is a quick fix. Hopefully I will be able to improve it:

  • Add a method to AnyEntityNode to be able to nullify the entity. Needed in order to iterate over all aliases and set them to nil.

@pjechris pjechris added the bug Something isn't working label Mar 27, 2024
@pjechris pjechris merged commit 055a2d2 into main Mar 27, 2024
2 checks passed
@pjechris pjechris deleted the fix/removeAlias-postChanges branch March 27, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant