use toArrayUnsafe to avoid copying the array

pjfanning · May 16, 2024 · 68a9495 · 68a9495
1 parent f119ed1
commit 68a9495
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/pekko-http-avro4s/src/main/scala/com/github/pjfanning/pekkohttpavro4s/AvroSupport.scala b/pekko-http-avro4s/src/main/scala/com/github/pjfanning/pekkohttpavro4s/AvroSupport.scala
@@ -111,7 +111,7 @@ trait AvroSupport {
         val schema = AvroSchema[A]
 
         Try {
-          val bytes = bs.toArray
+          val bytes = bs.toArrayUnsafe
           if (bytes.length == 0) throw Unmarshaller.NoContentException
           AvroInputStream.json[A].from(bytes).build(schema).iterator.next()
         }

diff --git a/pekko-http-jackson/src/main/scala/com/github/pjfanning/pekkohttpjackson/JacksonSupport.scala b/pekko-http-jackson/src/main/scala/com/github/pjfanning/pekkohttpjackson/JacksonSupport.scala
@@ -205,7 +205,7 @@ trait JacksonSupport {
       objectMapper: ObjectMapper with ClassTagExtensions = defaultObjectMapper
   ): Unmarshaller[ByteString, A] =
     Unmarshaller { _ => bs =>
-      Future.fromTry(Try(objectMapper.readValue[A](bs.toArray)))
+      Future.fromTry(Try(objectMapper.readValue[A](bs.toArrayUnsafe)))
     }
 
   /**

diff --git a/...ala/src/main/scala/com/github/pjfanning/pekkohttpjsoniterscala/JsoniterScalaSupport.scala b/...ala/src/main/scala/com/github/pjfanning/pekkohttpjsoniterscala/JsoniterScalaSupport.scala
@@ -136,7 +136,7 @@ trait JsoniterScalaSupport {
       codec: JsonValueCodec[A],
       config: ReaderConfig = defaultReaderConfig
   ): Unmarshaller[ByteString, A] =
-    Unmarshaller(_ => bs => Future.fromTry(Try(readFromArray(bs.toArray, config))))
+    Unmarshaller(_ => bs => Future.fromTry(Try(readFromArray(bs.toArrayUnsafe, config))))
 
   /**
     * HTTP entity => `Source[A, _]`

diff --git a/pekko-http-ninny/src/main/scala/com/github/pjfanning/pekkohttpninny/NinnySupport.scala b/pekko-http-ninny/src/main/scala/com/github/pjfanning/pekkohttpninny/NinnySupport.scala
@@ -91,7 +91,7 @@ trait NinnySupport {
     */
   implicit def fromByteStringUnmarshaller[A: FromJson]: Unmarshaller[ByteString, A] =
     Unmarshaller(_ =>
-      bs => Future.fromTry(Json.parse(new String(bs.toArray, StandardCharsets.UTF_8)).to[A])
+      bs => Future.fromTry(Json.parse(new String(bs.toArrayUnsafe, StandardCharsets.UTF_8)).to[A])
     )
 
   /**

diff --git a/...ttp-play-json/src/main/scala/com/github/pjfanning/pekkohttpplayjson/PlayJsonSupport.scala b/...ttp-play-json/src/main/scala/com/github/pjfanning/pekkohttpplayjson/PlayJsonSupport.scala
@@ -140,7 +140,7 @@ trait PlayJsonSupport {
     *   unmarshaller for any `A` value
     */
   implicit def fromByteStringUnmarshaller[A: Reads]: Unmarshaller[ByteString, A] =
-    Unmarshaller(_ => bs => Future.fromTry(Try(Json.parse(bs.toArray).as[A])))
+    Unmarshaller(_ => bs => Future.fromTry(Try(Json.parse(bs.toArrayUnsafe).as[A])))
 
   /**
     * HTTP entity => `Source[A, _]`

diff --git a/...le/src/main/scala/com/github/pjfanning/pekkohttpupickle/UpickleCustomizationSupport.scala b/...le/src/main/scala/com/github/pjfanning/pekkohttpupickle/UpickleCustomizationSupport.scala
@@ -110,7 +110,7 @@ trait UpickleCustomizationSupport {
     *   unmarshaller for any `A` value
     */
   implicit def fromByteStringUnmarshaller[A: api.Reader]: Unmarshaller[ByteString, A] =
-    Unmarshaller(_ => bs => Future.fromTry(Try(api.read(bs.toArray))))
+    Unmarshaller(_ => bs => Future.fromTry(Try(api.read(bs.toArrayUnsafe))))
 
   /**
     * HTTP entity => `A`