Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ByteString.toArrayUnsafe to avoid copying the array #17

Merged
merged 2 commits into from
May 16, 2024

Conversation

pjfanning
Copy link
Owner

ByteString does not mutate its underling array(s). As long as the JSON libs don't mess with the byte array, then 'unsafe' is ok.

@pjfanning pjfanning changed the title use toArrayUnsafe to avoid copying the array use ByteString.toArrayUnsafe to avoid copying the array May 16, 2024
@pjfanning pjfanning merged commit 7b8b114 into main May 16, 2024
2 checks passed
@pjfanning pjfanning deleted the toArrayUnsafe branch May 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant