inputs again

pkdawson · Jun 30, 2024 · a828d1d · a828d1d
1 parent 77f01da
commit a828d1d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/actions/install-godot/action.yml b/.github/actions/install-godot/action.yml
@@ -6,11 +6,14 @@ inputs:
     required: true
   dotnet:
     description: Use .NET build
-    required: true
+    required: false
+    default: 'false'
 
 runs:
   using: composite
   steps:
+    # TODO: .NET templates
+
     # 4.3.0-beta.2 -> 4.3.beta2
     # https://github.com/godotengine/godot-builds/releases/download/4.3-beta2/Godot_v4.3-beta2_export_templates.tpz
     - if: contains(inputs.version, 'beta')
@@ -54,22 +57,21 @@ runs:
         dotnet-version: 8.0.x
 
     - name: Install Godot
-      if: "!inputs.dotnet"
+      if: inputs.dotnet != 'true'
       shell: bash
       run: |
         dotnet tool install --global Chickensoft.GodotEnv
         godotenv godot install ${{ inputs.version }} --no-dotnet
         echo "GODOT=$(godotenv godot env path)" >> $GITHUB_ENV
 
     - name: Install Godot (.NET)
-      if: inputs.dotnet
+      if: inputs.dotnet == 'true'
       shell: bash
       run: |
         dotnet tool install --global Chickensoft.GodotEnv
         godotenv godot install ${{ inputs.version }}
         echo "GODOT=$(godotenv godot env path)" >> $GITHUB_ENV
 
-    # TODO: .NET templates
     - name: Install export templates
       shell: bash
       run: |

diff --git a/.github/workflows/gdext.yml b/.github/workflows/gdext.yml
@@ -352,6 +352,7 @@ jobs:
   test:
     needs: [package]
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-14, windows-latest]
         gdver: ["4.2.2", "4.3.0-beta.2"]
@@ -387,7 +388,6 @@ jobs:
       - uses: ./.github/actions/install-godot
         with:
           version: ${{ matrix.gdver }}
-          dotnet: false
 
       - name: Prep
         shell: bash