Implement code quality suggestions #323

pkiraly · Dec 7, 2023 · d8bdeb5 · d8bdeb5
1 parent 14bb335
commit d8bdeb5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/main/java/de/gwdg/metadataqa/marc/cli/BLClassificationAnalysis.java b/src/main/java/de/gwdg/metadataqa/marc/cli/BLClassificationAnalysis.java
@@ -14,7 +14,6 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.Serializable;
-import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.util.List;

diff --git a/src/main/java/de/gwdg/metadataqa/marc/dao/record/Marc21BibliographicRecord.java b/src/main/java/de/gwdg/metadataqa/marc/dao/record/Marc21BibliographicRecord.java
@@ -36,38 +36,44 @@ public Marc21BibliographicRecord(String id) {
     super(id);
   }
 
+  @Override
   public Control008 getControl008() {
     return (Control008) this.control008;
   }
 
+  @Override
   public void setControl008(MarcPositionalControlField control008) {
     this.control008 = control008;
     control008.setMarcRecord(this);
     controlfieldIndex.put(control008.getDefinition().getTag(), Arrays.asList(control008));
   }
 
 
+  @Override
   public List<DataField> getAuthorityFields() {
     if (authorityTags == null) {
       initializeAuthorityTags();
     }
     return getAuthorityFields(authorityTags);
   }
 
+  @Override
   public Map<DataField, AuthorityCategory> getAuthorityFieldsMap() {
     if (authorityTags == null) {
       initializeAuthorityTags();
     }
     return getAuthorityFields(authorityTagsMap);
   }
 
+  @Override
   public boolean isAuthorityTag(String tag) {
     if (authorityTagsIndex == null) {
       initializeAuthorityTags();
     }
     return authorityTagsIndex.getOrDefault(tag, false);
   }
 
+  @Override
   public boolean isSkippableAuthoritySubfield(String tag, String code) {
     if (authorityTagsIndex == null)
       initializeAuthorityTags();
@@ -78,13 +84,15 @@ public boolean isSkippableAuthoritySubfield(String tag, String code) {
     return skippableAuthoritySubfields.get(tag).getOrDefault(tag, false);
   }
 
+  @Override
   public boolean isSubjectTag(String tag) {
     if (subjectTagIndex == null) {
       initializeAuthorityTags();
     }
     return subjectTagIndex.getOrDefault(tag, false);
   }
 
+  @Override
   public boolean isSkippableSubjectSubfield(String tag, String code) {
     if (subjectTagIndex == null)
       initializeAuthorityTags();
@@ -122,6 +130,7 @@ private void initializeAuthorityTags() {
     authorityTagsMap.put(AuthorityCategory.OTHER, List.of("720", "753", "754"));
   }
 
+  @Override
   public Map<ThompsonTraillFields, List<String>> getThompsonTraillTagsMap() {
     if (thompsonTraillTagMap == null)
       initializeThompsonTraillTags();
@@ -152,6 +161,7 @@ private void initializeThompsonTraillTags() {
     thompsonTraillTagMap.put(ThompsonTraillFields.COUNTRY_OF_PUBLICATION, Arrays.asList("008/15"));
   }
 
+  @Override
   public Map<ShelfReadyFieldsBooks, Map<String, List<String>>> getShelfReadyMap() {
     if (shelfReadyMap == null)
       initializeShelfReadyMap();