Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust MARC authority record definition to Avram format #370

Closed
nichtich opened this issue Nov 24, 2023 · 1 comment · Fixed by #371
Closed

Adjust MARC authority record definition to Avram format #370

nichtich opened this issue Nov 24, 2023 · 1 comment · Fixed by #371

Comments

@nichtich
Copy link
Collaborator

Following #363 and timathom/marc-schema#1 to make class Marc21SchemaReader an Avram schema reader (at least for Marc schemas, but may be extended for PICA schemas as well).
@nichtich nichtich mentioned this issue Nov 24, 2023
Merged
@nichtich
Copy link
Collaborator Author

nichtich commented Nov 24, 2023 •
edited
Loading

Missing from #371:

  • rename key leader to LDR
  • change object indicators with keys 1 and 2 to indicator1 and indicator2:
    jq '.fields[]|=(.indicators as $i|if $i then (.+{indicator1:($i|.["1"]),indicator2:($i|.["2"])}|del(.indicators)) else . end)' src/main/resources/marc/authority-schema.json
  • remove key static, its value is implied by existence of codes
  • change value of positions to an Avram position object

The additional value key in codes will be inclued as code in Avram specification, so this should also be renamed.

@nichtich nichtich reopened this Dec 8, 2023
nichtich added a commit that referenced this issue Dec 11, 2023
@nichtich
Avram schema: Rename 'leader' to 'LDR' (#370)
798c926
nichtich added a commit that referenced this issue Dec 11, 2023
@nichtich
Avram schema: Remove 'static' (#370)
c2a9be9
nichtich added a commit that referenced this issue Dec 11, 2023
@nichtich
Avram schema: Rename 'value' to 'code' (#370)
0de4967
pkiraly pushed a commit that referenced this issue Dec 11, 2023
@nichtich
Extend migration of MARC authority record definition to Avram (#370) (#…
72c30d8 
…380)

* Avram schema: Rename 'leader' to 'LDR' (#370)

* Avram schema: Remove 'static' (#370)

* Avram schema: Rename 'value' to 'code' (#370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First steps to convert MARC schema to Avram format pkiraly/qa-catalogue
1 participant
@nichtich