Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps to convert MARC schema to Avram format #371

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

nichtich
Copy link
Collaborator

Partly resolves #370 by simple modification of the format as listed at timathom/marc-schema#1:

  • wrap the list of fields in a root object with key 'fields' and add key family with value 'marc'
  • rename key 'name' to 'label'
  • rename key 'values' to 'codes'
  • rename key 'staticValues' to 'positions'
  • remove key 'fixed', its value is implied by non-existence of 'subfields'

As listed at <timathom/marc-schema#1>:

- wrap the list of fields in a root object with key 'fields' and add key family with value 'marc'
- rename key 'name' to 'label'
- rename key 'values' to 'codes'
- rename key 'staticValues' to 'positions'
- remove key 'fixed', its value is implied by non-existence of 'subfields'
@pkiraly
Copy link
Owner

pkiraly commented Dec 6, 2023

@nichtich Sorry I just reviewed this PR. I would like to keep both versions and your versions of the class and the schema. Why? Because the maintainer of this schema is @timathom and he might have an existing infrastructure which supports his naming conventions, while it is equally important that there should be an Avram compatible version. So my suggestion: name your Marc21SchemaReader.java to AvramMarc21SchemaReader.java, and I will rename the old one to something like YaleMarc21SchemaReader. For the same reason I will rename the existing schema authority-schema.yale.json, and you should rename yours to authority-schema.avram.json. Do you agree?

@pkiraly
Copy link
Owner

pkiraly commented Dec 6, 2023

@nichtich I have just modified the existing files, so you can rename your versions.

@timathom
Copy link

timathom commented Dec 7, 2023

Thanks for your consideration, @pkiraly, but there's no need to maintain the naming conventions I used. I haven't yet built anything that depends on them, so, I'm more than happy to align with Avram!

@pkiraly
Copy link
Owner

pkiraly commented Dec 7, 2023

@timathom Thanks for the clarification!
@nichtich You do not need any further action yet. I'll do the modifications.

@pkiraly pkiraly merged commit e795b07 into main Dec 7, 2023
1 check passed
@pkiraly
Copy link
Owner

pkiraly commented Dec 7, 2023

I fixed the conflicts, now both schema versions and both handlers are available in the code base.

Copy link

sonarcloud bot commented Dec 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

81.4% 81.4% Coverage
48.9% 48.9% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nichtich nichtich deleted the marc-schema-avram branch December 11, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust MARC authority record definition to Avram format
3 participants