-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last non-Avram keys from exported schema #405
Conversation
Removes codes from JSON export until referenced codelists have been implemented. Apart from #402 this makes the exported schema (without Solr) valid Avram 0.9.6.
@nichtich I am fine with removing |
I hesitate to add more cases and rules to core Avram, especially when there are alternatives. Adding {
"positions":{
"01-04":{
"label":"Illustrations",
"url":"https://www.loc.gov/marc/bibliographic/bd006.html",
"flags": { ← like codes but repeatable to fill length of 4 characters
" ":{"label":"No illustrations"}, ← length of flag (here 1 for " ") must be proper divisor of 4
"a":{"label":"Illustrations"},
"b":{"label":"Maps"}, |
I am fine with this solution, so you can go further with it in this PR. |
Avram specification 0.9.6 contains I'm extending the pull request to also solve #402. |
I adjusted the UNIMARC schema reader to adapt the current changes ( |
As discussed at <#405> use `flags` instead of `codes` with `repeatableContent`.
Thanks for reminder. I directly committed to the main branch with an update. |
No description provided.