Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last non-Avram keys from exported schema #405

Closed
wants to merge 2 commits into from

Conversation

nichtich
Copy link
Collaborator

No description provided.

Removes codes from JSON export until referenced codelists have been
implemented. Apart from #402 this makes the exported schema (without
Solr) valid Avram 0.9.6.
@pkiraly
Copy link
Owner

pkiraly commented Jan 16, 2024

@nichtich I am fine with removing unitLenght, but I would like to keep the repeatableContent flag at least when it is true. We can remove it when it is false (because that is the normal case). Could you imagine to put repeatableContent to Avram schema?

@nichtich
Copy link
Collaborator Author

I hesitate to add more cases and rules to core Avram, especially when there are alternatives. Adding repeatableContent would require to clearly define its semantics. How about an alternative to codes for repeatable elements:

{
  "positions":{
    "01-04":{
      "label":"Illustrations",
      "url":"https://www.loc.gov/marc/bibliographic/bd006.html",
      "flags": {  ← like codes but repeatable to fill length of 4 characters
        " ":{"label":"No illustrations"}, ← length of flag (here 1 for " ") must be proper divisor of 4
        "a":{"label":"Illustrations"},
        "b":{"label":"Maps"},

@pkiraly
Copy link
Owner

pkiraly commented Jan 16, 2024

I am fine with this solution, so you can go further with it in this PR.
I have however some concerns that potential future users of Avram will find it a bit confusing that same thing have different names.

@nichtich
Copy link
Collaborator Author

Avram specification 0.9.6 contains flags as part of data element definitions in positions with an example from MARC 21 Bibliographic field 008. There is a corresponding validation rule invalidFlag.

I'm extending the pull request to also solve #402.

@pkiraly
Copy link
Owner

pkiraly commented Jan 20, 2024

I adjusted the UNIMARC schema reader to adapt the current changes (flags and codelist).

@pkiraly
Copy link
Owner

pkiraly commented Feb 26, 2024

@nichtich What is the status of this PR? You wrote „I'm extending the pull request to also solve #402” but there were no more commits after this comment.

nichtich added a commit that referenced this pull request Apr 4, 2024
nichtich added a commit that referenced this pull request Apr 4, 2024
As discussed at <#405> use
`flags` instead of `codes` with `repeatableContent`.
nichtich added a commit that referenced this pull request Apr 4, 2024
This makes Avram export from MARC21 valid Avram as discussed in
#405 and
#402.
@nichtich
Copy link
Collaborator Author

nichtich commented Apr 4, 2024

Thanks for reminder. I directly committed to the main branch with an update.

@nichtich nichtich closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants