Adjust UNIMARC Schema to Avram 0.9.6 #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following positions have been changed from `codes` to `flags` because they contain repeatable flags, filled with blanks: - `100$a/17-19` - `110$a/4-6` - `120$a/3-6`, `120$a/9-16` - `105$a/0-3`, `105$a/4-7` - `115$a/11-14` - `116$a/4-9`, `116$a/10-15` - `117$a/2-7` - `121$a/1-2`, - `126$a/7-12` - `140$a/0-3`, `140$a/4-7`, `140$a/9-16` - `141$a/0-2`, `141$a/6-7`, `141$d/0-2`, `141$e/0-2`, `141$e/3-5` - `145$b/5-6`, `145$c/5-6`, `145$d/5-6` - `181$b/3-5` In addition codes like "0-9", "1-9" must be made explicit as [0,]1,2,3,4,5,6,7,8,9: - `145$b/7`, `145$c/7`, `145$d/7` and `121$b/6` In these cases the number of distinct codes is better be expressed with a pattern: - `121$b/2-3` - `135$a/5-9` Additional documentation of the pattern requires <dini-ag-kim/avram#34> to be included in Avram specification.
The codelists contained invalid ISO 639-2 codes and was repeated. Better use a referenced codelist.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace several
codeswithflagswhen codes can be repeated and replace ranges such as0-9with patterns or explicit lists of codes. This makes the schema valid Avram 0.9.6 as tested with avram-js 0.6.6.@gegic This requires to also extend
UnimarcSchemaReadermethodgetPositionsto support:patternto specify a position (121$b/02-03and135$a/05-07)flagsalternative tocodeswhen a code must be repeated to fill a position (extendgetPositions)groupsto document pattern groups (this can be ignored as it is only for documentation, not for validation)and
codeswith string value referencing a codelist defined via root elementcodelists)By the way in qa-catalogue MARC validaton
flagsare internally stored likecodeswith an additional boolean flagrepeatableContents.