Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing timeout #1489

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Add Missing timeout #1489

merged 2 commits into from
Dec 23, 2024

Conversation

chris-rudmin
Copy link
Contributor

@chris-rudmin chris-rudmin commented Dec 5, 2024

_timeout is expected on PlexClient

Description

Please include a summary of the change and which issue is fixed.

Fixes #1490

Type of change

Fix PlexSonosClient missing _timeout on self

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

_timeout is expected on PlexClient
@JonnyWong16
Copy link
Collaborator

Could you add timeout to the arguments?

def __init__(self, server=None, data=None, initpath=None, baseurl=None,
identifier=None, token=None, connect=True, session=None, timeout=None,
parent=None):

self._timeout = timeout or TIMEOUT

Add keyword arguments
@chris-rudmin
Copy link
Contributor Author

Could you add timeout to the arguments?

def __init__(self, server=None, data=None, initpath=None, baseurl=None,
identifier=None, token=None, connect=True, session=None, timeout=None,
parent=None):

self._timeout = timeout or TIMEOUT

08c8496

@chris-rudmin
Copy link
Contributor Author

Test failures are on master branch and seem unrelated to my changes (tests/test_video.py::test_video_Movie_attrs[anonymously] ). All sonos tests are passing

@JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 merged commit 0df73f5 into pkkid:master Dec 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'PlexSonosClient' object has no attribute '_timeout'
2 participants