Add Web of Science Reviewer Recognition Service plugin for OJS 3.1, update for OJS 3.4

[Alex-nz]

• Add Web of Science Reviewer Recognition Service plugin for OJS 3.1 into the plugin gallery.
• Update version of the plugin for OJS 3.4

[Alex-nz]

hi team, can someone please code review this PR to add releases for the WoS RRS plugin. Previous PR for this plugin was reviewed by @bozana #301

[bozana]

Hi @Alex-nz,
For your version 1.3.1.0 I would suggest that you add addRoleAssignment, function authorize, and the check if($request->getContext()->getId() != $journalId) { as in the version I reviewed before.
I also think that you should leave the version 1.3.4.1 here in the plugins.xml, because someone could already be using it, and to just add the new 1.3.4.2 version. What is actually the change from 1.3.4.1 and 1.3.4.2?
Thanks a lot!

[Alex-nz]

Thanks for the review @bozana.

For your version 1.3.1.0 I would suggest that you add addRoleAssignment, function authorize, and the check if($request->getContext()->getId() != $journalId) { as in the version I reviewed before.

Is this critical for the approval? It's an older version of the plugin and we were hoping to simply re-brand it from Publons, without investing much time in re-writing.

I also think that you should leave the version 1.3.4.1 here in the plugins.xml, because someone could already be using it, and to just add the new 1.3.4.2 version. What is actually the change from 1.3.4.1 and 1.3.4.2?

Ok, I wasn't sure of the process here and actually was wondering if that's going to be a better way. I'll update that.

[bozana]

Hi @Alex-nz, lets leave the first point as it is -- no need to invest more time into it.
Is there any difference between 1.3.4.1 and 1.3.4.2?
If no, only 1.3.4.1 could stay.
Else, once you added 1.3.4.1 version into plugins.xml again, I can merge...

[Alex-nz]

thank you @bozana .
Sorry, I forgot to reply to the question about the difference! There is a small change to locale files only (one URL needed to be updated). No other changes. Does it warrant a new version? If so, I'll put it alongside the 1.3.4.1, not replacing it.

[Alex-nz]

I'll update the PR tomorrow then, thank you

[Alex-nz]

@bozana this is ready for re-review, please.

[bozana]

Thanks @Alex-nz, merged. It takes a few minutes till it is available for users in the Plugin Gallery...