Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI-LIBRARY][main] #10669 Change Version support for publications #488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
pkp/pkp-lib#4860 Initial Commit
defstat committed Jan 15, 2025
commit fbdd6cfb2e78810a47e55c093e3f5274756576a0
2 changes: 1 addition & 1 deletion public/globals.js
Original file line number Diff line number Diff line change
@@ -620,7 +620,7 @@ window.pkp = {
'publication.unschedule': 'Unschedule',
'publication.unschedule.confirm':
"Are you sure you don't want this scheduled for publication?",
'publication.version': 'Version {$version}',
'publication.version': '{$version}',
'publication.version.all': 'All Versions',
'publication.version.confirm':
'Are you sure you want to create a new version?',
8 changes: 4 additions & 4 deletions src/components/Container/WorkflowPage.stories.js
Original file line number Diff line number Diff line change
@@ -127,7 +127,7 @@ const WorkflowPageWithDataAndTemplate = {
class="pkpPublication__version"
>
<strong tabindex="0">{{ versionLabel }}</strong>
{{ workingPublication.version }}
{{ workingPublication.versionDataDisplay }}
<Dropdown
class="pkpPublication__versions"
label="All Versions"
@@ -144,7 +144,7 @@ const WorkflowPageWithDataAndTemplate = {
:disabled="publication.id === workingPublication.id"
@click="setWorkingPublicationById(publication.id)"
>
{{ publication.version }} /
{{ publication.versionDataDisplay }} /
<template
v-if="
publication.status === getConstant('STATUS_QUEUED') &&
@@ -448,13 +448,13 @@ const WorkflowPageWithDataAndTemplate = {
id: currentPublication.id,
datePublished: currentPublication.datePublished,
status: currentPublication.status,
version: currentPublication.version,
version: currentPublication.versionDataDisplay,
},
{
id: latestPublication.id,
datePublished: latestPublication.datePublished,
status: latestPublication.status,
version: latestPublication.version,
version: latestPublication.versionDataDisplay,
},
],
publicationTabsLabel: 'Publication details for version {$version}',
4 changes: 2 additions & 2 deletions src/components/Container/WorkflowPage.vue
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ export default {
*/
currentPublicationTabsLabel() {
return this.replaceLocaleParams(this.publicationTabsLabel, {
version: this.workingPublication.version,
version: this.workingPublication.versionDataDisplay,
});
},
},
@@ -611,7 +611,7 @@ export default {
if (publication.id === newPublication.id) {
publication.datePublished = newPublication.datePublished;
publication.status = newPublication.status;
publication.version = newPublication.version;
publication.versionDataDisplay = newPublication.versionDataDisplay;
}
});
},
2 changes: 1 addition & 1 deletion src/components/ListPanel/doi/DoiListPanel.vue
Original file line number Diff line number Diff line change
@@ -921,7 +921,7 @@ export default {
return {
id: publication.id,
isCurrentVersion: item.currentPublicationId === publication.id,
versionNumber: publication.version,
versionNumber: publication.versionDataDisplay,
urlPublished: publication.urlPublished,
datePublished: publication.datePublished,
};
2 changes: 1 addition & 1 deletion src/components/ListPanel/doi/DoiListPanelOJS.vue
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ export default {
originalItem.publications.forEach((publication) => {
const isCurrentVersion =
publication.id === this.getCurrentPublication(originalItem).id;
const versionNumber = publication.version;
const versionNumber = publication.versionDataDisplay;
if (this.enabledDoiTypes.includes('publication')) {
let doiObject = publication.doiObject;
2 changes: 1 addition & 1 deletion src/components/ListPanel/doi/DoiListPanelOMP.vue
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ export default {
originalItem.publications.forEach((publication) => {
const isCurrentVersion =
publication.id === this.getCurrentPublication(originalItem).id;
const versionNumber = publication.version;
const versionNumber = publication.versionDataDisplay;
// Submissions
if (this.enabledDoiTypes.includes('publication')) {
2 changes: 1 addition & 1 deletion src/components/ListPanel/doi/DoiListPanelOPS.vue
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ export default {
originalItem.publications.forEach((publication) => {
const isCurrentVersion =
publication.id === this.getCurrentPublication(originalItem).id;
const versionNumber = publication.version;
const versionNumber = publication.versionDataDisplay;
// Submissions
if (this.enabledDoiTypes.includes('publication')) {
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@
{{ t('semicolon', {label: t('admin.version')}) }}
</span>
<span class="text-base-normal">
{{ selectedPublication.version }}
{{ selectedPublication.versionDataDisplay }}
</span>
<span class="ms-2">
<DropdownActions
@@ -71,7 +71,9 @@ const statusProps = computed(() => {
});
function getItemLabel(publication) {
const firstPart = t('publication.version', {version: publication.version});
const firstPart = t('publication.version', {
version: publication.versionDataDisplay,
});
let secondPart = '';
if (
publication.status === pkp.const.STATUS_QUEUED &&