pkp/pkp-lib#10768 Add warning messages for author/reviewer combined w…

…ith editor

src/composables/useCurrentUser.js

@@ -50,10 +50,19 @@ export function useCurrentUser() {
 		return roles.some((role) => assignedRoleIds.includes(role));
 	}
 
+	function isCurrentUserAssignedAsReviewer(submission) {
+		const {getActiveReviewAssignments} = useSubmission();
+
+		return getActiveReviewAssignments(submission.reviewAssignments).some(
+			(reviewAssignment) => reviewAssignment.isCurrentUserAssigned,
+		);
+	}
+
 	return {
 		hasCurrentUserAtLeastOneRole,
 		getCurrentUserId,
 		hasCurrentUserAtLeastOneAssignedRoleInStage,
 		hasCurrentUserAtLeastOneAssignedRoleInAnyStage,
+		isCurrentUserAssignedAsReviewer,
 	};
 }

src/pages/dashboard/components/DashboardTable/DashboardCellSubmissionActions.vue

@@ -15,14 +15,51 @@
 import {defineProps, computed} from 'vue';
 import PkpButton from '@/components/Button/Button.vue';
 import TableCell from '@/components/Table/TableCell.vue';
-import {useDashboardPageStore} from '@/pages/dashboard/dashboardPageStore.js';
+import {useCurrentUser} from '@/composables/useCurrentUser';
+
+import {
+	DashboardPageTypes,
+	useDashboardPageStore,
+} from '@/pages/dashboard/dashboardPageStore.js';
+
+const {
+	hasCurrentUserAtLeastOneAssignedRoleInAnyStage,
+	isCurrentUserAssignedAsReviewer,
+} = useCurrentUser();
 
 const props = defineProps({
 	item: {type: Object, required: true},
 });
 
-const showButton = computed(() => !props.item.submissionProgress);
+const showButton = computed(() => {
+	if (props.item.submissionProgress) {
+		return false;
+	}
+
+	if (
+		dashboardPageStore.dashboardPage === DashboardPageTypes.EDITORIAL_DASHBOARD
+	) {
+		// Don't show View button, when being author/reviewer on editorial dashboard while not being explicitely assigned to editorial role
 
+		const isCurrentUserAssignedAsAuthorOrReviewer =
+			isCurrentUserAssignedAsReviewer(props.item) ||
+			hasCurrentUserAtLeastOneAssignedRoleInAnyStage(props.item, [
+				pkp.const.ROLE_ID_AUTHOR,
+			]);
+		if (
+			isCurrentUserAssignedAsAuthorOrReviewer &&
+			!hasCurrentUserAtLeastOneAssignedRoleInAnyStage(props.item, [
+				pkp.const.ROLE_ID_MANAGER,
+				pkp.const.ROLE_ID_SUB_EDITOR,
+				pkp.const.ROLE_ID_ASSISTANT,
+			])
+		) {
+			return false;
+		}
+	}
+
+	return true;
+});
 function handleAction() {
 	dashboardPageStore.openWorkflowModal(props.item.id);
 }

src/pages/dashboard/components/DashboardTable/DashboardCellSubmissionActivity/DashboardCellSubmissionActivityActionAlert.vue

@@ -1,5 +1,5 @@
 <template>
-	<div class="flex items-center gap-x-2">
+	<div class="flex max-w-sm items-center gap-x-2 break-words">
 		<div v-if="alert">{{ alert }}</div>
 		<PkpButton v-if="actionName" size-variant="compact" @click="handleAction">
 			{{ actionLabel }}

src/pages/dashboard/composables/useDashboardConfigEditorialActivity.js

@@ -2,6 +2,8 @@ import {
 	useSubmission,
 	CompletedReviewAssignmentStatuses,
 } from '@/composables/useSubmission.js';
+import {useCurrentUser} from '@/composables/useCurrentUser';
+
 import {useLocalize} from '@/composables/useLocalize';
 import {useDate} from '@/composables/useDate';
 import {Actions as ParticipantManagerActions} from '@/managers/ParticipantManager/useParticipantManagerActions';
@@ -20,6 +22,11 @@ const {
 	getStageLabel,
 } = useSubmission();
 
+const {
+	hasCurrentUserAtLeastOneAssignedRoleInAnyStage,
+	isCurrentUserAssignedAsReviewer,
+} = useCurrentUser();
+
 export function useDashboardConfigEditorialActivity() {
 	function getEditorialActivityForEditorialDashboard(submission) {
 		const activeStage = getActiveStage(submission);
@@ -51,6 +58,55 @@ export function useDashboardConfigEditorialActivity() {
 			];
 		}
 
+		// Warning that I am assigned as author, relevant if I am NOT assigned via any editorial role
+		if (
+			hasCurrentUserAtLeastOneAssignedRoleInAnyStage(submission, [
+				pkp.const.ROLE_ID_AUTHOR,
+			]) &&
+			!hasCurrentUserAtLeastOneAssignedRoleInAnyStage(submission, [
+				pkp.const.ROLE_ID_MANAGER,
+				pkp.const.ROLE_ID_SUB_EDITOR,
+				pkp.const.ROLE_ID_ASSISTANT,
+			])
+		) {
+			return [
+				{
+					component: 'DashboardCellSubmissionActivityActionAlert',
+					props: {
+						alert: t('dashboard.noAccessBeingAuthor'),
+					},
+				},
+			];
+		}
+
+		// Warning that I am assigned as author, relevant if I am NOT assigned via any editorial role
+		console.log('hola hej!');
+		console.log(isCurrentUserAssignedAsReviewer(submission));
+		console.log(
+			!hasCurrentUserAtLeastOneAssignedRoleInAnyStage(submission, [
+				pkp.const.ROLE_ID_MANAGER,
+				pkp.const.ROLE_ID_SUB_EDITOR,
+				pkp.const.ROLE_ID_ASSISTANT,
+			]),
+		);
+		if (
+			isCurrentUserAssignedAsReviewer(submission) &&
+			!hasCurrentUserAtLeastOneAssignedRoleInAnyStage(submission, [
+				pkp.const.ROLE_ID_MANAGER,
+				pkp.const.ROLE_ID_SUB_EDITOR,
+				pkp.const.ROLE_ID_ASSISTANT,
+			])
+		) {
+			return [
+				{
+					component: 'DashboardCellSubmissionActivityActionAlert',
+					props: {
+						alert: t('dashboard.noAccessBeingReviewer'),
+					},
+				},
+			];
+		}
+
 		if (activeStage.id === pkp.const.WORKFLOW_STAGE_ID_SUBMISSION) {
 			if (!submission.editorAssigned) {
 				return [