Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix data length in client hello #433

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

airycanon
Copy link
Contributor

close #424

Copy link
Member

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution and swift action!
Left a couple of remarks, once these are resolved I think we are good to merge this first and excellent contribution of yours. Thank you!

@airycanon airycanon requested a review from GlenDC February 26, 2025 10:02
@airycanon
Copy link
Contributor Author

@GlenDC Thanks for you guidance, could you please take another look.

Copy link
Member

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll let the CI do its thing now and in case that all passes this is good to merge.

Thank you for your contribution.

@GlenDC
Copy link
Member

GlenDC commented Feb 26, 2025

@GlenDC Thanks for you guidance, could you please take another look.

Looks good, but you need to do some formatting:

just qa

^ can you run that command. Or in case you do not have just and do not want it, I think for your purpose it might already be enough to run:

cargo fmt --all
cargo check --workspace --all-targets --all-features
cargo clippy --workspace --all-targets --all-features

@GlenDC GlenDC merged commit a58bfdf into plabayo:main Feb 26, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Len 0 values logged as 0x in responses
2 participants