Skip to content

Turning off compression when Perlbal X-Reproxy-Url header set #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Turning off compression when Perlbal X-Reproxy-Url header set #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Plack/Middleware/Deflater.pm
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ sub call {
return if $env->{HTTP_CONTENT_RANGE};

my $h = Plack::Util::headers($res->[1]);

# do not compress Perlbal reproxy URLs
return if $h->get('X-REPROXY-URL');

my $content_type = $h->get('Content-Type') || '';
$content_type =~ s/(;.*)$//;
if ( my $match_cts = $self->content_type ) {
Expand Down
36 changes: 36 additions & 0 deletions t/headers.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
use strict;
use Test::More;
#use Test::Requires qw(IO::Handle::Util);
#use IO::Handle::Util qw(:io_from);
use HTTP::Request::Common;
use Plack::Builder;
use Plack::Test;
use Plack::Middleware::Deflater;
$Plack::Test::Impl = "Server";

# no compression on X-REPROXY-URL
my $app = builder {
enable 'Deflater', content_type => 'text/html', vary_user_agent => 1;
sub {
[ 200,
[ 'Content-Length' => '100',
'Content-type' => 'text/plain',
'X-REPROXY-URL' =>
'http://10.0.0.1:7500/dev1/0/000/000/0000000001.fid',
],
['http://10.0.0.1:7500/dev1/0/000/000/0000000001.fid'],
];
}
};

test_psgi
app => $app,
client => sub {
my $cb = shift;
my $req = HTTP::Request->new( GET => "http://localhost/" );
my $res = $cb->($req);
isnt $res->content_encoding, 'gzip', 'no content-encoding';
};

done_testing;