-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new Erply Api options Could include more #11
base: main
Are you sure you want to change the base?
Conversation
@@ -2,9 +2,7 @@ | |||
""" | |||
ErplyAPI | |||
~~~~~~~~ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep existing empty lines in the docstrings. Please check PEP 257.
@@ -67,21 +64,26 @@ class Erply(object): | |||
,'getEmployees' | |||
,'getProducts' | |||
,'getProductCategories' | |||
,'getProductCostForSpecificAmount' # untested | |||
,'getProductCostForSpecificAmount' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this API call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
,'getProductUnits' | ||
,'getPurchaseDocuments' | ||
,'getReports' | ||
,'getSalesDocuments' | ||
,'getServices' | ||
,'getWarehouses' | ||
,'getAllowedWarehouses' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is supposed to be alphabetically ordered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry For that
) | ||
ERPLY_CSV = ('getProductStockCSV', 'getSalesReport') | ||
ERPLY_POST = ('saveProduct',) | ||
ERPLY_CSV = ('getProductStockCSV', 'getSalesReport','getPurchaseReport') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetic order please.
ERPLY_CSV = ('getProductStockCSV', 'getSalesReport') | ||
ERPLY_POST = ('saveProduct',) | ||
ERPLY_CSV = ('getProductStockCSV', 'getSalesReport','getPurchaseReport') | ||
ERPLY_POST = ('saveProduct') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removed comma is needed as ERPLY_POST
variable is filled with tuple of strings. With your change you turned it to just single string..
I have added some new api requests which I have tested. More could be added though