Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add EmbeddedLinkView.web shim #574

Merged

Conversation

adamhari
Copy link
Contributor

@adamhari adamhari commented Oct 11, 2023

fixes #564

Summary

Added an EmbeddedLinkView.web.tsx shim file which causes web bundlers to ignore the EmbeddedLinkView.tsx file which imports requireNativeComponent (causing a runtime error with react-native-web)

Motivation

We use Plaid on web and native with react-plaid-link and react-native-plaid-link-sdk respectively along with platform-specific file extensions in a universal app. Our implementation has been working up until 10.6.0, this shim resolves the web error and enables users to stay up to date on all platforms.

📝 Checklist

  • I have performed a self-review of my own code.
  • I have optimized code readability (class/variable names, straight forward logic paths, short clarifying docs,...).

💚 Testing

  • I have manually tested my changes.

Tested and confirmed to work with local projects.

@dtroupe-plaid dtroupe-plaid changed the base branch from master to develop October 11, 2023 17:36
dtroupe-plaid
dtroupe-plaid previously approved these changes Oct 11, 2023
Copy link
Collaborator

@dtroupe-plaid dtroupe-plaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamhari I pointed this at develop. Lets just add a comment to explain why that shim file exists and this is good to go. I can create a release this week once this is merged.

src/EmbeddedLink/EmbeddedLinkView.web.tsx Show resolved Hide resolved
@adamhari
Copy link
Contributor Author

@dtroupe-plaid thank you for the prompt response

@dtroupe-plaid dtroupe-plaid merged commit 729cb7d into plaid:develop Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React native web doesn't work with 10.6.0
2 participants