-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add EmbeddedLinkView.web shim #574
Merged
dtroupe-plaid
merged 10 commits into
plaid:develop
from
adamhari:fix-require-native-component-web-error
Oct 11, 2023
Merged
fix: add EmbeddedLinkView.web shim #574
dtroupe-plaid
merged 10 commits into
plaid:develop
from
adamhari:fix-require-native-component-web-error
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Release] 10.6.0
chore: update package-lock.json version
dtroupe-plaid
previously approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamhari I pointed this at develop. Lets just add a comment to explain why that shim file exists and this is good to go. I can create a release this week once this is merged.
Co-authored-by: dtroupe-plaid <[email protected]>
@dtroupe-plaid thank you for the prompt response |
dtroupe-plaid
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #564
Summary
Added an
EmbeddedLinkView.web.tsx
shim file which causes web bundlers to ignore theEmbeddedLinkView.tsx
file which importsrequireNativeComponent
(causing a runtime error withreact-native-web
)Motivation
We use Plaid on web and native with
react-plaid-link
andreact-native-plaid-link-sdk
respectively along with platform-specific file extensions in a universal app. Our implementation has been working up until10.6.0
, this shim resolves the web error and enables users to stay up to date on all platforms.📝 Checklist
💚 Testing
Tested and confirmed to work with local projects.