Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve autoupdate round 4 #39

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

lldelisle
Copy link
Contributor

Sorry I found again unexpected behaviours:

@lldelisle
Copy link
Contributor Author

Another unexpected behaviour see galaxyproject/planemo#1478

@lldelisle
Copy link
Contributor Author

Another 'failure': because of | tee to write stderr to file, the exit code of this command is always 0, even if the planemo autoupdate had an exit code of 1. I added set -o pipefail to keep an exit code of 1.

@bgruening
Copy link
Collaborator

The bot is saying I should remove the branch, but I have bgruening/galaxytools#1354 (comment)

@lldelisle
Copy link
Contributor Author

Yes, this will be solved by 3085c45

@lldelisle
Copy link
Contributor Author

May I merge this? @nsoranzo @mvdbeek

@nsoranzo nsoranzo merged commit 410cb28 into planemo-autoupdate:main Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants