Sensitive content analysis #1689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Overall this looks good and seems to work well. I did notice an issue where I was unable to open the image viewer when I tapped an image in a gallery (this may be true for single images in a post, too). I wonder if something here might be overriding the tap recognizer for images?
|
We still want to review and merge this, but it's going to be a few weeks before we have the bandwidth. Can you close this one and reopen in about a month @bryanmontz? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
I'm not sure if there's a ticket for this.
Description
Adds sensitive content analysis, Apple's built-in system for detecting nudity in images.
How to test
First make sure that Sensitive Content Warning is enabled at the OS level. Go to Settings.app -> Privacy & Security -> Sensitive Content Warning.
The real analyzer will be used in this state. If you want to see how the UI feels when content is flagged but without actually exposing yourself to sensitive content, go to the Settings view in Nos and override the analyzer to always flag either or both downloaded and uploaded images.
Screenshots/Video
When images are flagged as sensitive or you have overridden the analyzer in Settings:
When you try to upload an image that is flagged or you have overridden the analyzer in Settings:
