Update certs lane to be able to renew distribution certificate when i… #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mplorentz
requested review from
joshuatbrown,
pelumy and
bryanmontz
as code owners
joshuatbrown
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
https://github.com/verse-pbc/issues/issues/97
Description
Updated the certs lane to correctly renew the distribution cert. I removed the development cert part since it was causing errors and I don't think we need it because we do automatic signing for development builds.
How to test
I already ran the new lane locally. I guess you could run it again locally if you want by following these new docs, but it will destroy and recreate the certs which could cause any in-progress deployments to fail.
Alternatively you can check out this run of the deployment Action which was failing but now succeeded.