Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account test #112

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Account test #112

wants to merge 19 commits into from

Conversation

ademuanthony
Copy link
Contributor

@ademuanthony ademuanthony commented Feb 28, 2020 •
edited
Loading

This PR add tests for account operations in the accounts.go file.

The PR use github.com/onsi/ginkgo and github.com/onsi/gomega as introduced by @RogueElement in his on going PR #96.

image

@ademuanthony ademuanthony changed the title Account test [WIP] Account test Feb 28, 2020
@ademuanthony ademuanthony changed the title [WIP] Account test Account test Feb 28, 2020
oluwandabira
oluwandabira suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@oluwandabira oluwandabira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Describe's don't need to have the full method signature, we can't overload methods in go so just the name would suffice.

oluwandabira
oluwandabira reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@oluwandabira oluwandabira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git ignore the test rootDir

oluwandabira
oluwandabira reviewed Mar 16, 2020
View reviewed changes
oluwandabira
oluwandabira reviewed Mar 16, 2020
View reviewed changes
oluwandabira
oluwandabira reviewed Mar 16, 2020
View reviewed changes
itswisdomagain
itswisdomagain suggested changes Apr 26, 2020
View reviewed changes
ademuanthony and others added 18 commits April 29, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oluwandabira oluwandabira oluwandabira requested changes

@itswisdomagain itswisdomagain itswisdomagain requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademuanthony @itswisdomagain @oluwandabira