prevent more than one wallet from using the same seed #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beansgum
suggested changes
May 24, 2020
| // returns an error if there is any | ||
| func (mw *MultiWallet) checkForSeedClash(encryptedSeed []byte) error { | ||
| for _, wal := range mw.wallets { | ||
| if bytes.Equal(wal.EncryptedSeed, encryptedSeed) { |
There was a problem hiding this comment.
EncryptedSeed cannot be used to compare because the encrypted value is different for every encryption, EncryptedSeed is cleared once a wallet is backed up and EncryptedSeed is only saved for new wallets.
|
Closing this since it's stale and doesn't fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature that prevents more than one wallet from using the same seed.
Fixes #132