Multi: v2 staking design #1016

Sirmorrison · 2022-07-18T19:37:29Z

Resolves #981
Fix #1014
Fix #976
Fix #1005
Fix #1022
Fix #978

Fix wallet selector page display when app loads for the first time.
Fix backup modal notification display for wallet that don't have their seed phrase backed up.
Update the staking layout to the v2 layout design
Update stake shuffle and staking page to single wallet selector approach (needed to test the account selector)
Fix crash when staking page button is clicked twice
Fix ticket list refresh bug
Fix app crash when the settings button is clicked when a watch only wallet is selected.

dreacot · 2022-07-26T14:05:11Z

Description needs to be updated, because from what i'm seeing it looks like the work is incomplete, and that might have been intentional as follow up PRs are planned, but i'm not sure, can the description state the overall expectation of this PR(including what's purposely left out) and it we are expecting follow up PRs on this

Sirmorrison · 2022-07-26T15:12:26Z

Description needs to be updated, because from what i'm seeing it looks like the work is incomplete, and that might have been intentional as follow up PRs are planned, but i'm not sure, can the description state the overall expectation of this PR(including what's purposely left out) and it we are expecting follow up PRs on this

The PR resolves everything mentioned above. The next PR is the tx details page, and that does not really have anything to do with this PR.

dreacot

Navigating to the staking page cause a overall lag of the app for a couple of seconds.

All tickets are showing at once which isn't efficient and most likely the cause of the lag. the list should be paginated.
clicking on the settings icon on the staking page causes a crash
The statistic dialog is no same as that of the desing

5. there should be more right margin after the settings icon, and stake should be in bold

6. This section should be titledTickets and the icons don't seem to be on par with the provided figma design

the hover on tickets doesn't have a proper padding
The staking details page doesn't yet seem to be on par with the figma design

Sirmorrison · 2022-07-26T15:44:44Z

2. All tickets are showing at once which isn't efficient and most likely the cause of the lag. the list should be paginated.

clicking on the settings icon on the staking page causes a crash attach log please
All tickets are showing at once which isn't efficient and most likely the cause of the lag. the list should be paginated. for this, we will need to open a new PR
probably fix with the tx page. Fix UI lag on transactions page #939
The statistic dialog is no same as that of the desing there is a default godcr modal design which was used. Having to implement this design means changing the godcr modal design which wont be uniform. Was to bring it up on the design group.. Skipped my mind.
The staking details page doesn't yet seem to be on par with the figma design this is coming in a different PR as the design is a tx details design overhaul.

dreacot · 2022-07-26T15:48:00Z

clicking on the settings icon on the staking page causes a crash attach log please

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x120a09b]

goroutine 14 [running]:
github.com/planetdecred/godcr/ui/page/components.(*AccountSelector).Layout.func2({{{0x0, 0x0}, {0x114, 0xf41fc}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/page/components/account_selector.go:181 +0x3b
gioui.org/layout.Flex.Layout({0xfa, 0x3d, 0x0, 0x0}, {{{0x0, 0x0}, {0x134, 0xf41fc}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/flex.go:99 +0xdb5
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2.1.1.1({{{0x0, 0x0}, {0x134, 0xf41fc}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:89 +0x85
gioui.org/layout.Direction.Layout(0x0, {{{0x0, 0x0}, {0x134, 0xf41fc}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:166 +0x162
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2.1.1({{{0x134, 0x0}, {0x134, 0xf41fc}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:88 +0xe5
gioui.org/layout.Inset.Layout({0x1bd0120, 0x0, 0x0, 0x80000000}, {{{0x134, 0x0}, {0x134, 0xf41fc}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:139 +0x3b6
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2.1({{{0x14c, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:86 +0x109
github.com/planetdecred/godcr/ui/decredmaterial.Border.Layout({{0xe6, 0xea, 0xed, 0xff}, {0x8, 0x8, 0x8, 0x8}, 0x40000000}, {{{0x14c, ...}, ...}, ...}, ...)
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/border.go:21 +0x98
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2({{{0x14c, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:84 +0x1d6
gioui.org/layout.Stack.Layout({0xff}, {{{0x0, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/stack.go:60 +0x8b6
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1({{{0x0, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:47 +0x2aa
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1({{{0x0, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:108 +0x238
gioui.org/layout.Inset.Layout({0x417c8a, 0x0, 0x41a154, 0x0}, {{{0x0, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:139 +0x3b6
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1({{{0x0, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:44 +0x109
gioui.org/layout.Direction.Layout(0x0, {{{0x0, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:166 +0x162
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout({0xfffffffffffffffe, 0xffffffffffffffff, 0x0, {0x0, 0x0, 0x0, 0x0}, 0x0, {{0xe6, 0xea, ...}, ...}, ...}, ...)
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:42 +0xe5
github.com/planetdecred/godcr/ui/page/components.(*AccountSelector).Layout(0xc003526f00, {0x1dcc100, 0xc00043d3b0}, {{{0x14c, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/page/components/account_selector.go:170 +0x4a5
github.com/planetdecred/godcr/ui/page/staking.(*ticketBuyerModal).Layout.func2.1.1({{{0x14c, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/page/staking/stake_modal.go:126 +0x87
gioui.org/layout.Inset.Layout({0x5d0c, 0x0, 0x2899440, 0xc0}, {{{0x14c, 0x0}, {0x14c, 0xf4214}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:139 +0x3b6
github.com/planetdecred/godcr/ui/page/staking.(*ticketBuyerModal).Layout.func2.1({{{0x14c, 0x0}, {0x14c, 0xf422c}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/page/staking/stake_modal.go:125 +0xaf
gioui.org/layout.Flex.Layout({0x0, 0x0, 0x0, 0x0}, {{{0x14c, 0x0}, {0x14c, 0xf422c}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/flex.go:99 +0xdb5
github.com/planetdecred/godcr/ui/page/staking.(*ticketBuyerModal).Layout.func2({{{0x14c, 0x0}, {0x14c, 0xf422c}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/page/staking/stake_modal.go:120 +0x255
gioui.org/layout.Inset.Layout({0x3df6, 0x0, 0x3df5, 0x0}, {{{0x14c, 0x0}, {0x14c, 0xf422c}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:139 +0x3b6
github.com/planetdecred/godcr/ui/decredmaterial.(*Modal).Layout.func2.1.2.2({{{0x14c, 0x0}, {0x14c, 0xf4240}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...}, ...)
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/modal.go:167 +0x85
gioui.org/layout.(*List).Layout(0xc0061bd800, {{{0x14c, 0x0}, {0x14c, 0xf4240}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/list.go:117 +0x17c
github.com/planetdecred/godcr/ui/decredmaterial.(*Modal).Layout.func2.1.2({{{0x14c, 0x0}, {0x14c, 0x196}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/modal.go:166 +0x2bd
gioui.org/layout.Flex.Layout({0xf2, 0x3d, 0x0, 0x0}, {{{0x0, 0x0}, {0x14c, 0x1c4}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/flex.go:99 +0xdb5
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2.1.1.1({{{0x0, 0x0}, {0x14c, 0x1c4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:89 +0x85
gioui.org/layout.Direction.Layout(0x8, {{{0x0, 0x0}, {0x14c, 0x1c4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:166 +0x162
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2.1.1({{{0x0, 0x0}, {0x14c, 0x1c4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:88 +0xe5
gioui.org/layout.Inset.Layout({0x0, 0x0, 0x0, 0x0}, {{{0x0, 0x0}, {0x14c, 0x1c4}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:139 +0x3b6
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2.1({{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:86 +0x109
github.com/planetdecred/godcr/ui/decredmaterial.Border.Layout({{0x0, 0x0, 0x0, 0x0}, {0xe, 0xe, 0xe, 0xe}, 0x0}, {{{0x0, ...}, ...}, ...}, ...)
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/border.go:21 +0x98
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1.2({{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:84 +0x1d6
gioui.org/layout.Stack.Layout({0x40}, {{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/stack.go:60 +0x8b6
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1.1({{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:47 +0x2aa
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1.1({{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:108 +0x238
gioui.org/layout.Inset.Layout({0x3fb47b13, 0xa, 0x2ed12a0, 0x0}, {{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:139 +0x3b6
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout.func1({{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:44 +0x109
gioui.org/layout.Direction.Layout(0x8, {{{0x0, 0x0}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:166 +0x162
github.com/planetdecred/godcr/ui/decredmaterial.LinearLayout.Layout({0xffffffffffffffff, 0xffffffffffffffff, 0x1, {0xff, 0xff, 0xff, 0xff}, 0x0, {{0x0, 0x0, ...}, ...}, ...}, ...)
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/linearlayout.go:42 +0xe5
github.com/planetdecred/godcr/ui/decredmaterial.(*Modal).Layout.func2.1({{{0x0, 0x1f4}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/modal.go:130 +0x3ac
gioui.org/layout.Inset.Layout({0xf51688, 0x0, 0xfffffffe, 0xffffffff}, {{{0x0, 0x1f4}, {0x17c, 0x1f4}}, {0x3f800000, 0x3f800000}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/layout.go:139 +0x3b6
github.com/planetdecred/godcr/ui/decredmaterial.(*Modal).Layout.func2({{{0x0, 0x258}, {0x17c, 0x258}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/modal.go:118 +0x2f4
gioui.org/layout.Stack.Layout({0x75}, {{{0x0, 0x0}, {0x320, 0x258}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/stack.go:60 +0x8b6
github.com/planetdecred/godcr/ui/decredmaterial.(*Modal).Layout(0xc0072f8fa0, {{{0x0, 0x0}, {0x320, 0x258}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/decredmaterial/modal.go:91 +0x2ad
github.com/planetdecred/godcr/ui/page/staking.(*ticketBuyerModal).Layout(0xc005225700, {{{0x0, 0x0}, {0x320, 0x258}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/page/staking/stake_modal.go:158 +0x185
github.com/planetdecred/godcr/ui.(*Window).prepareToDisplayUI.func3({{{0x0, 0x0}, {0x320, 0x258}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, 0xa3fb47b13, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/window.go:234 +0x58
gioui.org/layout.Stack.Layout({0x40}, {{{0x320, 0x258}, {0x320, 0x258}}, {0x3f800000, 0x3f800000}, {0x1d7bbe0, 0xc00001f8e8}, {0xc0b020fccc6fe14c, ...}, ...}, ...)
        /home/kennedy/Projects/pkg/mod/[email protected]/layout/stack.go:60 +0x8b6
github.com/planetdecred/godcr/ui.(*Window).prepareToDisplayUI(0xc0000f5d60, {{0xc0b020fccc6fe14c, 0xa3fb47b13, 0x2ed12a0}, {0x3f800000, 0x3f800000}, {0x320, 0x258}, {0x0, 0x0, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/window.go:241 +0x42d
github.com/planetdecred/godcr/ui.(*Window).handleFrameEvent(0xc0000f5d60, {{0xc0b020fccc6fe14c, 0xa3fb47b13, 0x2ed12a0}, {0x3f800000, 0x3f800000}, {0x320, 0x258}, {0x0, 0x0, ...}, ...})
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/window.go:182 +0x227
github.com/planetdecred/godcr/ui.(*Window).HandleEvents(0xc0000f5d60)
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/ui/window.go:148 +0x156
main.main.func2()
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/main.go:80 +0x26
created by main.main
        /home/kennedy/Projects/src/github.com/planetdecred/godcr/main.go:79 +0x4d2
exit status 2

dreacot

clicking the settings icon isn't working, is that intentional?

Sirmorrison · 2022-07-28T05:53:56Z

clicking the settings icon isn't working, is that intentional?

if you are using a watch only wallet, yes it wont work as its watch only. but other wallets works.

- clean up redundant files and lines of code

Update stake shuffle to use single wallet selector approach Fix setting button margin bug Fix app crash when settings button is clicked due to watch only wallet selection Fix ticket list hover alignment bug Add title to ticket list section general code clean up

dreacot · 2022-07-28T10:59:01Z

clicking the settings icon isn't working, is that intentional?

if you are using a watch only wallet, yes it wont work as its watch only. but other wallets works.

alright, there's nothing indicating that, maybe we should use a toast?

JustinBeBoy · 2022-07-28T15:51:11Z

clicking the settings icon isn't working, is that intentional?

if you are using a watch only wallet, yes it wont work as its watch only. but other wallets works.

alright, there's nothing indicating that, maybe we should use a toast?

or shouldn't show it

JustinBeBoy

After confirm automatic Ticket Purchase the switcher not turn on then turn off without notice for user the reason.
Should uppercase the first character

ui/page/staking/stake_info.go

JustinBeBoy · 2022-07-28T16:19:51Z

We don't use description of ticket like mockup ?

Sirmorrison · 2022-07-28T18:43:17Z

After confirm automatic Ticket Purchase the switcher not turn on then turn off without notice for user the reason.
this seems to be a backend issue and will be resolved from dcrlibwallet. Ticket buyer stopping immediately after ticket buyer instance starts. dcrlibwallet#258

We don't use description of ticket like mockup ?

I dont understand this comment please.

Can you share a screenshot of the UI that did not align?

- Fix default app container size as it wax too small on full screen. - Adjust pading and localize and fix string variables typo

dreacot · 2022-07-29T15:25:10Z

LGTM @JustinBeBoy are you still having concerns?

@dreacot

already approved by @dreacot

Sirmorrison changed the title ~~add v2 staking alance layout~~ Multi: add v2 staking alance layout Jul 20, 2022

Sirmorrison changed the title ~~Multi: add v2 staking alance layout~~ Multi: v2 staking design Jul 20, 2022

Sirmorrison force-pushed the staking_v2 branch from 7511ac5 to b2ea773 Compare July 25, 2022 05:44

Sirmorrison marked this pull request as ready for review July 25, 2022 06:04

Sirmorrison force-pushed the staking_v2 branch from b2ea773 to 5c9de8c Compare July 25, 2022 07:59

dreacot previously requested changes Jul 26, 2022

View reviewed changes

dreacot assigned Sirmorrison Jul 26, 2022

Sirmorrison force-pushed the staking_v2 branch 2 times, most recently from 98fded7 to 0ef219e Compare July 27, 2022 17:35

dreacot reviewed Jul 27, 2022

View reviewed changes

Sirmorrison added 9 commits July 28, 2022 07:02

add v2 staking alance layout

0d5ae1e

add tickets list

aebd0b8

set backup modal deplay on selected wallet page load

e678c29

Add stake statistics modal

01df484

- clean up redundant files and lines of code

update ticket list item layout to v2 design

76f6e6b

fix ticket list alignment bug

d4ffc0f

fix app crash as a result of vsp selector

bb9c336

update account selector to v2 single wallet selection appraoch

19b725d

Sirmorrison force-pushed the staking_v2 branch from 0ef219e to 88f665d Compare July 28, 2022 06:04

JustinBeBoy suggested changes Jul 28, 2022

View reviewed changes

JustinBeBoy reviewed Jul 28, 2022

View reviewed changes

ui/page/staking/stake_info.go Outdated Show resolved Hide resolved

Hide staking buttons for watch-only wallets

d6ed4dd

- Fix default app container size as it wax too small on full screen. - Adjust pading and localize and fix string variables typo

JustinBeBoy approved these changes Jul 30, 2022

View reviewed changes

Sirmorrison merged commit b45dca8 into planetdecred:master Jul 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi: v2 staking design #1016

Multi: v2 staking design #1016

Sirmorrison commented Jul 18, 2022 •

edited

Loading

dreacot commented Jul 26, 2022

Sirmorrison commented Jul 26, 2022

dreacot left a comment

Sirmorrison commented Jul 26, 2022

dreacot commented Jul 26, 2022

dreacot left a comment

Sirmorrison commented Jul 28, 2022

dreacot commented Jul 28, 2022

JustinBeBoy commented Jul 28, 2022

JustinBeBoy left a comment

JustinBeBoy commented Jul 28, 2022

Sirmorrison commented Jul 28, 2022 •

edited

Loading

dreacot commented Jul 29, 2022

Multi: v2 staking design #1016

Multi: v2 staking design #1016

Conversation

Sirmorrison commented Jul 18, 2022 • edited Loading

dreacot commented Jul 26, 2022

Sirmorrison commented Jul 26, 2022

dreacot left a comment

Choose a reason for hiding this comment

Sirmorrison commented Jul 26, 2022

dreacot commented Jul 26, 2022

dreacot left a comment

Choose a reason for hiding this comment

Sirmorrison commented Jul 28, 2022

dreacot commented Jul 28, 2022

JustinBeBoy commented Jul 28, 2022

JustinBeBoy left a comment

Choose a reason for hiding this comment

JustinBeBoy commented Jul 28, 2022

Sirmorrison commented Jul 28, 2022 • edited Loading

dreacot commented Jul 29, 2022

Sirmorrison commented Jul 18, 2022 •

edited

Loading

Sirmorrison commented Jul 28, 2022 •

edited

Loading