Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch esprima sha hash #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patch esprima sha hash #186

wants to merge 1 commit into from

Conversation

amirahav
Copy link

What does this PR do?

Because we are using an older version of jshint, and it isn't using a specific esprima version we need to change the hash every now and again.

Screenshot

Related Issue

@travislbrundage
Copy link

So if you just rerun npm install locally, it fixes the messed up package-lock.json file, which does this and updates the version, which I believe should be 1.5.134 for both. So this line here: https://github.com/boundlessgeo/MapLoom/blob/master/package-lock.json#L3 should be 1.5.134, right?

Other than that 👍

@amirahav
Copy link
Author

It should be, but for some reason Jenkins always sets package-lock.json to one behind.
Let me push an update to this branch...

@travislbrundage travislbrundage mentioned this pull request Jun 25, 2018
@travislbrundage
Copy link

I made the change to jshint which seems to fix the esprima hash issues here: #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants