Merge pull request #108 from planetlabs/close-error

Return any error after closing
planetlabs · Oct 29, 2023 · 7c9dec6 · 7c9dec6
2 parents 8334081 + 6c1e8dd
commit 7c9dec6
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/internal/pqutil/transform.go b/internal/pqutil/transform.go
@@ -105,8 +105,6 @@ func TransformByColumn(config *TransformConfig) error {
 	}
 
 	fileWriter := file.NewParquetWriter(config.Writer, outputSchema.Root(), file.WithWriterProps(writerProperties))
-	defer fileWriter.Close()
-
 	ctx := pqarrow.NewArrowWriteContext(context.Background(), nil)
 
 	if config.RowGroupLength > 0 {
@@ -189,7 +187,9 @@ func TransformByColumn(config *TransformConfig) error {
 	}
 
 	if config.BeforeClose != nil {
-		return config.BeforeClose(fileReader, fileWriter)
+		if err := config.BeforeClose(fileReader, fileWriter); err != nil {
+			return err
+		}
 	}
-	return nil
+	return fileWriter.Close()
 }