Use proper Authn header when contacting capi-d #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be sending the oauth_* tokens in the header form ```Authorization: Bearer *``` as is described here: https://github.com/plangrid/customer_api_dispatcher#oauth-authentication We will support the existing authn in centauth but should move to the documented protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be sending the oauth_* tokens in the header form
Authorization: Bearer *as is described here: https://github.com/plangrid/customer_api_dispatcher#oauth-authenticationWe will support the existing authn in centauth but should move to the documented protocol.
Any way to test this? Have no experience with this repo or c#. Need to be sure that
AuthenticationHeaderValuedoesn't b64 encode the token value. The server expectsBearer oauth_tokenFound this doc which may help: https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/wiki/Using-the-acquired-token-to-call-a-protected-Web-API
This change is