Support zeitwerk (agileware-jp#11)

* Change the way file paths are written

* Change the module structure to match the file path with the module structure

* This is a change to support Zeitwerk
* I tried to change Concerns::IssueTemplate::Common to IssueTemplate::Common, but I changed it to IssueTemplateCommon because the IssueTemplate class existed.

app/controllers/concerns/issue_templates_common.rb

@@ -1,154 +1,152 @@
 # frozen_string_literal: true
 
-module Concerns
-  module IssueTemplatesCommon
-    extend ActiveSupport::Concern
+module IssueTemplatesCommon
+  extend ActiveSupport::Concern
 
-    class InvalidTemplateFormatError < StandardError; end
+  class InvalidTemplateFormatError < StandardError; end
 
-    included do
-      before_action :log_action, only: [:destroy]
+  included do
+    before_action :log_action, only: [:destroy]
 
-      # logging action
-      def log_action
-        logger&.info "[#{self.class}] #{action_name} called by #{User.current.name}"
-      end
+    # logging action
+    def log_action
+      logger&.info "[#{self.class}] #{action_name} called by #{User.current.name}"
+    end
 
-      def plugin_setting
-        Setting.plugin_redmine_issue_templates
-      end
+    def plugin_setting
+      Setting.plugin_redmine_issue_templates
+    end
 
-      def apply_all_projects?
-        plugin_setting['apply_global_template_to_all_projects'].to_s == 'true'
-      end
+    def apply_all_projects?
+      plugin_setting['apply_global_template_to_all_projects'].to_s == 'true'
+    end
 
-      def apply_template_when_edit_issue?
-        plugin_setting['apply_template_when_edit_issue'].to_s == 'true'
-      end
+    def apply_template_when_edit_issue?
+      plugin_setting['apply_template_when_edit_issue'].to_s == 'true'
+    end
 
-      def builtin_fields_enabled?
-        plugin_setting['enable_builtin_fields'].to_s == 'true'
-      end
+    def builtin_fields_enabled?
+      plugin_setting['enable_builtin_fields'].to_s == 'true'
     end
+  end
 
-    def load_selectable_fields
-      tracker_id = params[:tracker_id]
-      project_id = params[:project_id]
-      render plain: {} && return if tracker_id.blank?
+  def load_selectable_fields
+    tracker_id = params[:tracker_id]
+    project_id = params[:project_id]
+    render plain: {} && return if tracker_id.blank?
 
-      custom_fields = core_fields_map_by_tracker_id(tracker_id: tracker_id, project_id: project_id).merge(custom_fields_map_by_tracker_id(tracker_id))
-      render plain: { custom_fields: custom_fields }.to_json
-    end
+    custom_fields = core_fields_map_by_tracker_id(tracker_id: tracker_id, project_id: project_id).merge(custom_fields_map_by_tracker_id(tracker_id))
+    render plain: { custom_fields: custom_fields }.to_json
+  end
 
-    def orphaned_templates
-      render partial: 'common/orphaned', locals: { orphaned_templates: orphaned }
-    end
+  def orphaned_templates
+    render partial: 'common/orphaned', locals: { orphaned_templates: orphaned }
+  end
 
-    def apply_all_projects?
-      plugin_setting['apply_global_template_to_all_projects'].to_s == 'true'
-    end
+  def apply_all_projects?
+    plugin_setting['apply_global_template_to_all_projects'].to_s == 'true'
+  end
 
-    def builtin_fields_json
-      value = template_params[:builtin_fields].blank? ? {} : JSON.parse(template_params[:builtin_fields])
-      return value if value.is_a?(Hash)
+  def builtin_fields_json
+    value = template_params[:builtin_fields].blank? ? {} : JSON.parse(template_params[:builtin_fields])
+    return value if value.is_a?(Hash)
 
-      raise InvalidTemplateFormatError
-    end
+    raise InvalidTemplateFormatError
+  end
 
-    def valid_params
-      attributes = template_params.except(:builtin_fields)
-      attributes[:builtin_fields_json] = builtin_fields_json if builtin_fields_enabled?
-      attributes
-    end
+  def valid_params
+    attributes = template_params.except(:builtin_fields)
+    attributes[:builtin_fields_json] = builtin_fields_json if builtin_fields_enabled?
+    attributes
+  end
 
-    def destroy
-      raise NotImplementedError, "You must implement #{self.class}##{__method__}"
-    end
+  def destroy
+    raise NotImplementedError, "You must implement #{self.class}##{__method__}"
+  end
 
-    #
-    # TODO: Code should be refactored
-    #
-    def core_fields_map_by_tracker_id(tracker_id: nil, project_id: nil)
-      return {} unless builtin_fields_enabled?
-
-      fields = %w[status_id priority_id]
-      fields << 'watcher_user_ids' if project_id.present?
-
-      # exclude "description"
-      tracker = Tracker.find_by(id: tracker_id)
-      fields += tracker.core_fields.reject { |field| field == 'description' } if tracker.present?
-      fields.reject! { |field| %w[category_id fixed_version_id assigned_to_id].include?(field) } if project_id.blank?
-
-      map = {}
-
-      fields.each do |field|
-        id = "issue_#{field}"
-        name = I18n.t('field_' + field.gsub(/_id$/, ''))
-        value = { name: name, core_field_id: id }
-        if field == 'priority_id'
-          value[:possible_values] = IssuePriority.active.pluck(:name)
-          value[:field_format] = 'list'
-        end
-
-        if field == 'status_id' && tracker.present?
-          value[:possible_values] = tracker.issue_statuses.pluck(:name)
-          value[:field_format] = 'list'
-        end
-
-        if field == 'category_id' && project_id.present?
-          categories = IssueCategory.where(project_id: project_id)
-          value[:possible_values] = categories.pluck(:name)
-          value[:field_format] = 'list'
-        end
-
-        if field == 'assigned_to_id' && project_id.present?
-          project = Project.find(project_id)
-          assignable_users = (project.assignable_users(tracker).to_a + [project.default_assigned_to]).uniq.compact
-          value[:possible_values] = assignable_users.map { |user| user.name }
-          value[:field_format] = 'list'
-        end
-
-        if field == 'watcher_user_ids' && project_id.present?
-          issue = Issue.new(tracker_id: tracker_id, project_id: project_id)
-          watchers = helpers.users_for_new_issue_watchers(issue)
-          value[:field_format] = 'list'
-
-          value[:possible_values] = watchers.map { |user| "#{user.name} :#{user.id}" }
-          value[:name] = I18n.t('field_watcher')
-          value[:multiple] = true
-        end
-
-        value[:field_format] = 'date' if %(start_date due_date).include?(field)
-
-        value[:field_format] = 'ratio' if field == 'done_ratio'
-
-        map[id] = value
+  #
+  # TODO: Code should be refactored
+  #
+  def core_fields_map_by_tracker_id(tracker_id: nil, project_id: nil)
+    return {} unless builtin_fields_enabled?
+
+    fields = %w[status_id priority_id]
+    fields << 'watcher_user_ids' if project_id.present?
+
+    # exclude "description"
+    tracker = Tracker.find_by(id: tracker_id)
+    fields += tracker.core_fields.reject { |field| field == 'description' } if tracker.present?
+    fields.reject! { |field| %w[category_id fixed_version_id assigned_to_id].include?(field) } if project_id.blank?
+
+    map = {}
+
+    fields.each do |field|
+      id = "issue_#{field}"
+      name = I18n.t('field_' + field.gsub(/_id$/, ''))
+      value = { name: name, core_field_id: id }
+      if field == 'priority_id'
+        value[:possible_values] = IssuePriority.active.pluck(:name)
+        value[:field_format] = 'list'
+      end
+
+      if field == 'status_id' && tracker.present?
+        value[:possible_values] = tracker.issue_statuses.pluck(:name)
+        value[:field_format] = 'list'
+      end
+
+      if field == 'category_id' && project_id.present?
+        categories = IssueCategory.where(project_id: project_id)
+        value[:possible_values] = categories.pluck(:name)
+        value[:field_format] = 'list'
       end
-      map
-    rescue StandardError => e
-      logger&.info "core_fields_map_by_tracker_id failed due to this error: #{e.message}"
-      {}
-    end
 
-    def custom_fields_map_by_tracker_id(tracker_id = nil)
-      return {} unless builtin_fields_enabled?
-      return {} if tracker_id.blank?
+      if field == 'assigned_to_id' && project_id.present?
+        project = Project.find(project_id)
+        assignable_users = (project.assignable_users(tracker).to_a + [project.default_assigned_to]).uniq.compact
+        value[:possible_values] = assignable_users.map { |user| user.name }
+        value[:field_format] = 'list'
+      end
 
-      tracker = Tracker.find_by(id: tracker_id)
-      ids = tracker&.custom_field_ids || []
-      fields = IssueCustomField.where(id: ids)
-      map = {}
-      fields.each do |field|
-        id = "issue_custom_field_values_#{field.id}"
-        attributes = field.attributes
+      if field == 'watcher_user_ids' && project_id.present?
+        issue = Issue.new(tracker_id: tracker_id, project_id: project_id)
+        watchers = helpers.users_for_new_issue_watchers(issue)
+        value[:field_format] = 'list'
 
-        attributes = attributes.merge(possible_values: field.possible_values_options.map { |value| value[0] }) if field.format.name == 'bool'
-        map[id] = attributes
+        value[:possible_values] = watchers.map { |user| "#{user.name} :#{user.id}" }
+        value[:name] = I18n.t('field_watcher')
+        value[:multiple] = true
       end
-      map
-    rescue StandardError => e
-      logger&.info "core_fields_map_by_tracker_id failed due to this error: #{e.message}"
-      {}
+
+      value[:field_format] = 'date' if %(start_date due_date).include?(field)
+
+      value[:field_format] = 'ratio' if field == 'done_ratio'
+
+      map[id] = value
+    end
+    map
+  rescue StandardError => e
+    logger&.info "core_fields_map_by_tracker_id failed due to this error: #{e.message}"
+    {}
+  end
+
+  def custom_fields_map_by_tracker_id(tracker_id = nil)
+    return {} unless builtin_fields_enabled?
+    return {} if tracker_id.blank?
+
+    tracker = Tracker.find_by(id: tracker_id)
+    ids = tracker&.custom_field_ids || []
+    fields = IssueCustomField.where(id: ids)
+    map = {}
+    fields.each do |field|
+      id = "issue_custom_field_values_#{field.id}"
+      attributes = field.attributes
+
+      attributes = attributes.merge(possible_values: field.possible_values_options.map { |value| value[0] }) if field.format.name == 'bool'
+      map[id] = attributes
     end
+    map
+  rescue StandardError => e
+    logger&.info "core_fields_map_by_tracker_id failed due to this error: #{e.message}"
+    {}
   end
 end