Avoid parameter loss when sort issue_template (agileware-jp#61)

planio-gmbh · Mar 20, 2023 · ebca97f · ebca97f
1 parent 53fcf2a
commit ebca97f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/app/controllers/concerns/issue_templates_common.rb b/app/controllers/concerns/issue_templates_common.rb
@@ -55,6 +55,7 @@ def builtin_fields_json
   end
 
   def valid_params
+    return template_params unless template_params.has_key?(:builtin_fields)
     attributes = template_params.except(:builtin_fields)
     attributes[:builtin_fields_json] = builtin_fields_json if builtin_fields_enabled?
     attributes

diff --git a/spec/controllers/issue_templates_controller_spec.rb b/spec/controllers/issue_templates_controller_spec.rb
@@ -248,5 +248,15 @@
         expect(issue_template.reload.title).to eq 'Issue Template updated title for update test'
       end
     end
+
+    context 'update position' do
+      let(:update_params) { { issue_template: { position: 10 } } }
+      let(:issue_template) { create :issue_template, builtin_fields_json: { key: "value" }}
+
+      it 'not updated builtin_fields' do
+        issue_template.reload
+        expect(issue_template.builtin_fields_json).to eq({ key: "value" })
+      end
+    end
   end
 end