fix(client): only call .close() when needed (#90)

plastic-labs · Jan 9, 2025 · 91d9a14 · 91d9a14
1 parent 39eeb9c
commit 91d9a14
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/honcho/_base_client.py b/src/honcho/_base_client.py
@@ -767,6 +767,9 @@ def __init__(self, **kwargs: Any) -> None:
 
 class SyncHttpxClientWrapper(DefaultHttpxClient):
     def __del__(self) -> None:
+        if self.is_closed:
+            return
+
         try:
             self.close()
         except Exception:
@@ -1334,6 +1337,9 @@ def __init__(self, **kwargs: Any) -> None:
 
 class AsyncHttpxClientWrapper(DefaultAsyncHttpxClient):
     def __del__(self) -> None:
+        if self.is_closed:
+            return
+
         try:
             # TODO(someday): support non asyncio runtimes here
             asyncio.get_running_loop().create_task(self.aclose())