Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test actions and coverage #17

Merged
merged 11 commits into from
Feb 22, 2024
Merged

add test actions and coverage #17

merged 11 commits into from
Feb 22, 2024

Conversation

hyusap
Copy link
Collaborator

@hyusap hyusap commented Feb 14, 2024

No description provided.

Copy link

Code Coverage

Package Line Rate Complexity Health
honcho 87% 0
tests 100% 0
Summary 94% (783 / 834) 0

@hyusap hyusap marked this pull request as draft February 14, 2024 22:12
Copy link
Collaborator

@VVoruganti VVoruganti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change tests to use postgres and I think we are good

sleep 5
cd ..
env:
DATABASE_TYPE: sqlite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the addition of the pgvector stuff sqlite may not work. There is a docker-compose in main that has a postgresql instance with the pgvector extension in it. May need to do some kind of docker-compose type testing as well for testing

@hyusap hyusap merged commit 197a658 into staging Feb 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants