Merge pull request #23 from plastic-labs/dm/drop-contact-prompts

allow no prompt on giant links; remove them
plastic-labs · Dec 4, 2024 · 0a45ac5 · 0a45ac5
2 parents 58f2182 + 024b6d2
commit 0a45ac5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/components/composed/contact/contact.tsx b/components/composed/contact/contact.tsx
@@ -32,15 +32,13 @@ export const Contact: React.FC<ContactProps> = props => {
       <LinkGiant
         href="https://discord.gg/plasticlabs"
         inverse
-        prompt="To connect with Plastic Labs"
         text="Join Discord"
         title="Contact"
       />
       <Divider />
       <LinkGiant
         href="mailto:[email protected]"
         inverse
-        prompt="For other inquiries"
         text="Email [email protected]"
         title="Inquire"
       />

diff --git a/components/interactive/links/link-giant/link-giant.stories.tsx b/components/interactive/links/link-giant/link-giant.stories.tsx
@@ -54,7 +54,7 @@ const meta = {
       description: 'The link prompt',
       table: {
         defaultValue: {
-          summary: '[required]',
+          summary: 'undefined',
         },
         type: {
           summary: 'string',
@@ -131,7 +131,7 @@ export const LinkGiant: Story = {
   args: {
     href: 'https://plasticlabs.ai',
     inverse: false,
-    prompt: 'You very much want to click this',
+    prompt: '',
     text: 'Link Giant',
     title: 'This is a link',
   },

diff --git a/components/interactive/links/link-giant/link-giant.tsx b/components/interactive/links/link-giant/link-giant.tsx
@@ -147,7 +147,7 @@ export const LinkGiant: React.FC<LinkGiantProps> = ({
   title,
   ...props
 }) => {
-  if (!prompt || !text || !title) {
+  if (!text || !title) {
     return null
   }
 
@@ -156,7 +156,7 @@ export const LinkGiant: React.FC<LinkGiantProps> = ({
       <StyledTitle variant="Body1">{title}</StyledTitle>
       <IconUpRightArrow />
       <StyledDetails>
-        <StyledPrompt variant="Body1">{prompt}</StyledPrompt>
+        {prompt ? <StyledPrompt variant="Body1">{prompt}</StyledPrompt> : null}
         <Text variant="Body1">{text}</Text>
       </StyledDetails>
     </>

diff --git a/components/interactive/links/link-giant/link-giant.types.ts b/components/interactive/links/link-giant/link-giant.types.ts
@@ -6,7 +6,7 @@ export interface LinkGiantProps
   extends Omit<AnchorHTMLAttributes<HTMLAnchorElement>, 'href'>,
     LinkProps,
     SharedThemeProps {
-  prompt: string
+  prompt?: string
   text: string
   title: string
 }