Skip to content

Commit

Permalink
Merge pull request #508 from platanus/f/selected-list-redundant-label
Browse files Browse the repository at this point in the history
fix(selected-list): remove redundant (and w/ invalid html) label
  • Loading branch information
rjherrera authored Dec 6, 2024
2 parents fe81206 + b4b8906 commit ad98691
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

### Unreleased

#### Fixed

* Remove invalid HTML from selected list input to avoid error in Rails 7.2 [#507](https://github.com/platanus/activeadmin_addons/pull/507)

### 1.10.1

* Backport [#477](https://github.com/platanus/activeadmin_addons/pull/477) to have ActiveAdmin v3 compatibility [#479](https://github.com/platanus/activeadmin_addons/pull/479)
Expand Down
1 change: 0 additions & 1 deletion app/inputs/selected_list_input.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def load_control_attributes

def render_control_wrapper
template.content_tag(:div, class: "selected-list-container") do
template.content_tag(label_html)
template.concat(render_items_list)
template.concat(builder.select(build_virtual_attr, [], {}, input_html_options))
end
Expand Down

0 comments on commit ad98691

Please sign in to comment.