Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirm_message to toggle-bool-switch #498

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Add confirm_message to toggle-bool-switch #498

merged 6 commits into from
Sep 13, 2024

Conversation

mario-amazing
Copy link
Contributor

Motivation / Background

Add new confirm_message feature to toggle-bool-switch: #483

@mario-amazing
Copy link
Contributor Author

@difernandez, could you check it?

mpapis
mpapis reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mpapis mpapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I had use case to confirm only turning off - so extended with confirmation separately on or off.

app/javascript/activeadmin_addons/addons/toggle_bool.js Outdated Show resolved Hide resolved
docs/toggle_bool.md Outdated Show resolved Hide resolved
lib/activeadmin_addons/addons/toggle_bool_builder.rb Outdated Show resolved Hide resolved
rjherrera
rjherrera reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@rjherrera rjherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR and sorry for the long wait. I suggested something as I was worried about the implementation, let me know so we can merge this :)

app/javascript/activeadmin_addons/addons/toggle_bool.js Outdated Show resolved Hide resolved
rjherrera
rjherrera reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@rjherrera rjherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left the suggestions there

app/javascript/activeadmin_addons/addons/toggle_bool.js Outdated Show resolved Hide resolved
docs/toggle_bool.md Outdated Show resolved Hide resolved
lib/activeadmin_addons/addons/toggle_bool_builder.rb Outdated Show resolved Hide resolved
@rjherrera rjherrera merged commit afa8ee1 into platanus:master Sep 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjherrera rjherrera rjherrera left review comments

@mpapis mpapis mpapis left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mario-amazing @mpapis @rjherrera