Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build luigi, openvswitch images via github action #246

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

shweta50
Copy link
Contributor

@shweta50 shweta50 commented Sep 14, 2024

Image built via TC fails on certain hardware with core dumped error.
Building image via GitHub action with runs on : ubuntu-latest.

I have validated the image on the hardware it was failing on.
JIRA: https://platform9.atlassian.net/browse/PMK-6478

GitHub action triggers docker build and pushes images to dockerhub

@shweta50 shweta50 self-assigned this Sep 14, 2024
@shweta50 shweta50 force-pushed the private/shweta/ovsmultiarch branch from 6044462 to 398f91a Compare September 15, 2024 05:06
@shweta50 shweta50 changed the title Build openvswitch image via github action Build luigi, openvswitch images via github action Sep 15, 2024
@@ -1,4 +1,4 @@
FROM alpine:3.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the key change here that fixes the issues building on Teamcity. Same as #138

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to Alpine 3.16 in Hostplumber : Backport to v0.5.4 branch

Reason : Hostplumber build uses libexecinfo and libexecinfo-dev which has been removed in Alpine 3.17 - build fails in Teamcity with higher version of Alpine DataDog/dd-trace-php#1824

TODO: Can look into workarounds later to be able to support alpine 3.17 or higher YMMV : awslabs/aws-lambda-cpp#124 (comment)

Teamcity builds :

@cruizen
Copy link
Contributor

cruizen commented Sep 15, 2024

I have approved but we should call the targets make img-test / make test too to test the changes -beyond just building the image.

@shweta50 shweta50 force-pushed the private/shweta/ovsmultiarch branch from ab41d32 to e236bb7 Compare September 18, 2024 08:57
@shweta50 shweta50 merged commit 985de53 into master Sep 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants