Update go mod to use go1.21 and update compiler switches/ flags for static linking

[vedantjoshi84]

No description provided.

[cruizen]

Hi @vedantjoshi84 , I was talking to @mithilarun that the make build target looks right with the additional ldflags but we somehow still don't have a statically linked executable. He brought to my notice that the Teamcity build calls the script build.bash that calls the target make container-build. This target uses golang:1.18 and more importantly doesn't use the same flags (CGO_ENABLED=0 and the ldflags added recently).

[cruizen]

Suggested change

	docker run --rm --env XDG_CACHE_HOME=$(XDG_CACHE_HOME) --env SEGMENT_KEY_PRD_PMKFT=$(SEGMENT_KEY_PRD_PMKFT) --env VERSION_OVERRIDE=${VERSION_OVERRIDE} --env GOPATH=/tmp --env GOFLAGS=$(GOFLAGS) --user $(CONT_USER):$(CONT_GRP) --volume $(PWD):$(PACKAGE_GOPATH) $(GIT_STORAGE_MOUNT) --workdir $(PACKAGE_GOPATH) golang:1.18 make LDFLAGS="-s -w -extldflags '-static'"
	docker run --rm --env XDG_CACHE_HOME=$(XDG_CACHE_HOME) --env SEGMENT_KEY_PRD_PMKFT=$(SEGMENT_KEY_PRD_PMKFT) --env VERSION_OVERRIDE=${VERSION_OVERRIDE} --env GOPATH=/tmp --env GOFLAGS=$(GOFLAGS) --user $(CONT_USER):$(CONT_GRP) --volume $(PWD):$(PACKAGE_GOPATH) $(GIT_STORAGE_MOUNT) --workdir $(PACKAGE_GOPATH) golang:1.18 make ldflags="-s -w -extldflags '-static'"

[cruizen]

LDFLAGS is lowercase in the build target. Uppercase here.

[mithilarun]

@vedantjoshi84 I see that the LDFLAGS variable isn't used anymore. Why not make these changes to that variable directly?

[cruizen]

You should be able to pass ldflags as part of --env GOFLAGS as follows. Can you verify (the formatting may be incorrect here)?

container-build:
    docker run --rm \
--env XDG_CACHE_HOME=$(XDG_CACHE_HOME) \
--env SEGMENT_KEY_PRD_PMKFT=$(SEGMENT_KEY_PRD_PMKFT) \
--env VERSION_OVERRIDE=${VERSION_OVERRIDE} \
--env GOPATH=/tmp \
--env GOFLAGS="$(GOFLAGS) -ldflags '-s -w -extldflags \"-static\"'" \
--user $(CONT_USER):$(CONT_GRP) \
--volume $(PWD):$(PACKAGE_GOPATH) $(GIT_STORAGE_MOUNT) \
--workdir $(PACKAGE_GOPATH) \
golang:1.21 make

[cruizen]

Suggested a change in container-build