Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include instruction to run benchmark #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sudo-barun
Copy link

Related Issue: #12

@galvez
Copy link
Contributor

galvez commented Aug 28, 2024

You're missing the build step for all other examples.

@sudo-barun
Copy link
Author

@galvez I think build step for other examples is unnecessary. The steps are same other than changing directory. The last point should be enough to cover other examples.

@mxstbr
Copy link

mxstbr commented Aug 29, 2024

@sudo-barun you are incorrect. Without running pnpm build, all the other examples throw an error like this:

CleanShot 2024-08-29 at 11 42 46@2x

You have to run pnpm install && pnpm build && pnpm start to get them to run.

@sudo-barun
Copy link
Author

@mxstbr Thanks for the correction. I completely forgot that part. My bad.

I will update the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants