-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified dummy_interface struct to add prefixlen along with Address #99
Open
mj073
wants to merge
1
commit into
platinasystems:master
Choose a base branch
from
mj073:bug-30
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this basically the same as issue #30 ?
…On Wed, Jan 31, 2018 at 11:28 PM, mj073 ***@***.***> wrote:
After the fix following is the result when dummy interface is added:
***@***.***:~$ sudo goes vnet show ip fib
Table Destination Adjacency
default 10.0.4.0/24 3: glean eth-4-1
default 10.0.4.28/32 4: local eth-4-1
default 10.0.6.0/24 5: glean eth-6-1
default 10.0.6.28/32 6: local eth-6-1
default 10.0.8.0/24 7: glean eth-8-1
default 10.0.8.28/32 8: local eth-8-1
default 10.0.10.0/24 9: glean eth-10-1
default 10.0.10.28/32 10: local eth-10-1
default 10.0.12.0/24 11: glean eth-12-1
default 10.0.12.28/32 12: local eth-12-1
default 10.0.14.0/24 13: glean eth-14-1
default 10.0.14.28/32 14: local eth-14-1
default 10.0.16.0/24 15: glean eth-16-1
default 10.0.16.28/32 16: local eth-16-1
default 10.0.18.0/24 17: glean eth-18-1
default 10.0.18.28/32 18: local eth-18-1
default 10.0.20.0/24 19: glean eth-20-1
default 10.0.20.28/32 20: local eth-20-1
default 10.0.22.0/24 21: glean eth-22-1
default 10.0.22.28/32 22: local eth-22-1
default 10.0.24.0/24 23: glean eth-24-1
default 10.0.24.28/32 24: local eth-24-1
default 10.0.26.0/24 25: glean eth-26-1
default 10.0.26.28/32 26: local eth-26-1
default 10.0.28.0/24 27: glean eth-28-1
default 10.0.28.28/32 28: local eth-28-1
default 10.0.30.0/24 29: glean eth-30-1
default 10.0.30.28/32 30: local eth-30-1
default 10.0.32.0/24 31: glean eth-32-1
default 10.0.32.28/32 32: local eth-32-1
***@***.***:~$
***@***.***:~$ sudo ip addr show dummy0
Device "dummy0" does not exist.
***@***.***:~$ sudo ip link add dummy0 type dummy
***@***.***:~$ sudo ip add add 3.3.3.3/24 dev dummy0
***@***.***:~$ sudo ip addr show dummy0
28751: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN group default qlen 1000
link/ether 76:6c:05:0c:9e:82 brd ff:ff:ff:ff:ff:ff
inet 3.3.3.3/24 scope global dummy0
valid_lft forever preferred_lft forever
***@***.***:~$ sudo goes vnet show ip fib
Table Destination Adjacency
default 10.0.4.0/24 3: glean eth-4-1
default 10.0.4.28/32 4: local eth-4-1
default 10.0.6.0/24 5: glean eth-6-1
default 10.0.6.28/32 6: local eth-6-1
default 10.0.8.0/24 7: glean eth-8-1
default 10.0.8.28/32 8: local eth-8-1
default 10.0.10.0/24 9: glean eth-10-1
default 10.0.10.28/32 10: local eth-10-1
default 10.0.12.0/24 11: glean eth-12-1
default 10.0.12.28/32 12: local eth-12-1
default 10.0.14.0/24 13: glean eth-14-1
default 10.0.14.28/32 14: local eth-14-1
default 10.0.16.0/24 15: glean eth-16-1
default 10.0.16.28/32 16: local eth-16-1
default 10.0.18.0/24 17: glean eth-18-1
default 10.0.18.28/32 18: local eth-18-1
default 10.0.20.0/24 19: glean eth-20-1
default 10.0.20.28/32 20: local eth-20-1
default 10.0.22.0/24 21: glean eth-22-1
default 10.0.22.28/32 22: local eth-22-1
default 10.0.24.0/24 23: glean eth-24-1
default 10.0.24.28/32 24: local eth-24-1
default 10.0.26.0/24 25: glean eth-26-1
default 10.0.26.28/32 26: local eth-26-1
default 10.0.28.0/24 27: glean eth-28-1
default 10.0.28.28/32 28: local eth-28-1
default 10.0.30.0/24 29: glean eth-30-1
default 10.0.30.28/32 30: local eth-30-1
default 10.0.32.0/24 31: glean eth-32-1
default 10.0.32.28/32 32: local eth-32-1
***@***.***:~$ sudo ip link set dummy0 up
***@***.***:~$ sudo goes vnet show ip fib
Table Destination Adjacency
default 3.3.3.0/24 2: punt
default 3.3.3.3/32 2: punt
default 10.0.4.0/24 3: glean eth-4-1
default 10.0.4.28/32 4: local eth-4-1
default 10.0.6.0/24 5: glean eth-6-1
default 10.0.6.28/32 6: local eth-6-1
default 10.0.8.0/24 7: glean eth-8-1
default 10.0.8.28/32 8: local eth-8-1
default 10.0.10.0/24 9: glean eth-10-1
default 10.0.10.28/32 10: local eth-10-1
default 10.0.12.0/24 11: glean eth-12-1
default 10.0.12.28/32 12: local eth-12-1
default 10.0.14.0/24 13: glean eth-14-1
default 10.0.14.28/32 14: local eth-14-1
default 10.0.16.0/24 15: glean eth-16-1
default 10.0.16.28/32 16: local eth-16-1
default 10.0.18.0/24 17: glean eth-18-1
default 10.0.18.28/32 18: local eth-18-1
default 10.0.20.0/24 19: glean eth-20-1
default 10.0.20.28/32 20: local eth-20-1
default 10.0.22.0/24 21: glean eth-22-1
default 10.0.22.28/32 22: local eth-22-1
default 10.0.24.0/24 23: glean eth-24-1
default 10.0.24.28/32 24: local eth-24-1
default 10.0.26.0/24 25: glean eth-26-1
default 10.0.26.28/32 26: local eth-26-1
default 10.0.28.0/24 27: glean eth-28-1
default 10.0.28.28/32 28: local eth-28-1
default 10.0.30.0/24 29: glean eth-30-1
default 10.0.30.28/32 30: local eth-30-1
default 10.0.32.0/24 31: glean eth-32-1
default 10.0.32.28/32 32: local eth-32-1
***@***.***:~$ sudo ip link set dummy0 down
***@***.***:~$ sudo goes vnet show ip fib
Table Destination Adjacency
default 10.0.4.0/24 3: glean eth-4-1
default 10.0.4.28/32 4: local eth-4-1
default 10.0.6.0/24 5: glean eth-6-1
default 10.0.6.28/32 6: local eth-6-1
default 10.0.8.0/24 7: glean eth-8-1
default 10.0.8.28/32 8: local eth-8-1
default 10.0.10.0/24 9: glean eth-10-1
default 10.0.10.28/32 10: local eth-10-1
default 10.0.12.0/24 11: glean eth-12-1
default 10.0.12.28/32 12: local eth-12-1
default 10.0.14.0/24 13: glean eth-14-1
default 10.0.14.28/32 14: local eth-14-1
default 10.0.16.0/24 15: glean eth-16-1
default 10.0.16.28/32 16: local eth-16-1
default 10.0.18.0/24 17: glean eth-18-1
default 10.0.18.28/32 18: local eth-18-1
default 10.0.20.0/24 19: glean eth-20-1
default 10.0.20.28/32 20: local eth-20-1
default 10.0.22.0/24 21: glean eth-22-1
default 10.0.22.28/32 22: local eth-22-1
default 10.0.24.0/24 23: glean eth-24-1
default 10.0.24.28/32 24: local eth-24-1
default 10.0.26.0/24 25: glean eth-26-1
default 10.0.26.28/32 26: local eth-26-1
default 10.0.28.0/24 27: glean eth-28-1
default 10.0.28.28/32 28: local eth-28-1
default 10.0.30.0/24 29: glean eth-30-1
default 10.0.30.28/32 30: local eth-30-1
default 10.0.32.0/24 31: glean eth-32-1
default 10.0.32.28/32 32: local eth-32-1
***@***.***:~$ sudo ip link set dummy0 up
***@***.***:~$ sudo goes vnet show ip fib
Table Destination Adjacency
default 3.3.3.0/24 2: punt
default 3.3.3.3/32 2: punt
default 10.0.4.0/24 3: glean eth-4-1
default 10.0.4.28/32 4: local eth-4-1
default 10.0.6.0/24 5: glean eth-6-1
default 10.0.6.28/32 6: local eth-6-1
default 10.0.8.0/24 7: glean eth-8-1
default 10.0.8.28/32 8: local eth-8-1
default 10.0.10.0/24 9: glean eth-10-1
default 10.0.10.28/32 10: local eth-10-1
default 10.0.12.0/24 11: glean eth-12-1
default 10.0.12.28/32 12: local eth-12-1
default 10.0.14.0/24 13: glean eth-14-1
default 10.0.14.28/32 14: local eth-14-1
default 10.0.16.0/24 15: glean eth-16-1
default 10.0.16.28/32 16: local eth-16-1
default 10.0.18.0/24 17: glean eth-18-1
default 10.0.18.28/32 18: local eth-18-1
default 10.0.20.0/24 19: glean eth-20-1
default 10.0.20.28/32 20: local eth-20-1
default 10.0.22.0/24 21: glean eth-22-1
default 10.0.22.28/32 22: local eth-22-1
default 10.0.24.0/24 23: glean eth-24-1
default 10.0.24.28/32 24: local eth-24-1
default 10.0.26.0/24 25: glean eth-26-1
default 10.0.26.28/32 26: local eth-26-1
default 10.0.28.0/24 27: glean eth-28-1
default 10.0.28.28/32 28: local eth-28-1
default 10.0.30.0/24 29: glean eth-30-1
default 10.0.30.28/32 30: local eth-30-1
default 10.0.32.0/24 31: glean eth-32-1
default 10.0.32.28/32 32: local eth-32-1
***@***.***:~$ sudo goes restart
***@***.***:~$ sudo goes vnet show ip fib
Table Destination Adjacency
default 3.3.3.0/24 2: punt
default 3.3.3.3/32 2: punt
default 10.0.4.0/24 3: glean eth-4-1
default 10.0.4.28/32 4: local eth-4-1
default 10.0.6.0/24 5: glean eth-6-1
default 10.0.6.28/32 6: local eth-6-1
default 10.0.8.0/24 7: glean eth-8-1
default 10.0.8.28/32 8: local eth-8-1
default 10.0.10.0/24 9: glean eth-10-1
default 10.0.10.28/32 10: local eth-10-1
default 10.0.12.0/24 11: glean eth-12-1
default 10.0.12.28/32 12: local eth-12-1
default 10.0.14.0/24 13: glean eth-14-1
default 10.0.14.28/32 14: local eth-14-1
default 10.0.16.0/24 15: glean eth-16-1
default 10.0.16.28/32 16: local eth-16-1
default 10.0.18.0/24 17: glean eth-18-1
default 10.0.18.28/32 18: local eth-18-1
default 10.0.20.0/24 19: glean eth-20-1
default 10.0.20.28/32 20: local eth-20-1
default 10.0.22.0/24 21: glean eth-22-1
default 10.0.22.28/32 22: local eth-22-1
default 10.0.24.0/24 23: glean eth-24-1
default 10.0.24.28/32 24: local eth-24-1
default 10.0.26.0/24 25: glean eth-26-1
default 10.0.26.28/32 26: local eth-26-1
default 10.0.28.0/24 27: glean eth-28-1
default 10.0.28.28/32 28: local eth-28-1
default 10.0.30.0/24 29: glean eth-30-1
default 10.0.30.28/32 30: local eth-30-1
default 10.0.32.0/24 31: glean eth-32-1
default 10.0.32.28/32 32: local eth-32-1
***@***.***:~$ sudo ip add add 5.5.5.5/16 dev dummy0
***@***.***:~$ sudo goes vnet show ip fib
Table Destination Adjacency
default 3.3.3.0/24 2: punt
default 3.3.3.3/32 2: punt
default 5.5.0.0/16 2: punt
default 5.5.5.5/32 2: punt
default 10.0.4.0/24 3: glean eth-4-1
default 10.0.4.28/32 4: local eth-4-1
default 10.0.6.0/24 5: glean eth-6-1
default 10.0.6.28/32 6: local eth-6-1
default 10.0.8.0/24 7: glean eth-8-1
default 10.0.8.28/32 8: local eth-8-1
default 10.0.10.0/24 9: glean eth-10-1
default 10.0.10.28/32 10: local eth-10-1
default 10.0.12.0/24 11: glean eth-12-1
default 10.0.12.28/32 12: local eth-12-1
default 10.0.14.0/24 13: glean eth-14-1
default 10.0.14.28/32 14: local eth-14-1
default 10.0.16.0/24 15: glean eth-16-1
default 10.0.16.28/32 16: local eth-16-1
default 10.0.18.0/24 17: glean eth-18-1
default 10.0.18.28/32 18: local eth-18-1
default 10.0.20.0/24 19: glean eth-20-1
default 10.0.20.28/32 20: local eth-20-1
default 10.0.22.0/24 21: glean eth-22-1
default 10.0.22.28/32 22: local eth-22-1
default 10.0.24.0/24 23: glean eth-24-1
default 10.0.24.28/32 24: local eth-24-1
default 10.0.26.0/24 25: glean eth-26-1
default 10.0.26.28/32 26: local eth-26-1
default 10.0.28.0/24 27: glean eth-28-1
default 10.0.28.28/32 28: local eth-28-1
default 10.0.30.0/24 29: glean eth-30-1
default 10.0.30.28/32 30: local eth-30-1
default 10.0.32.0/24 31: glean eth-32-1
default 10.0.32.28/32 32: local eth-32-1
***@***.***:~$
------------------------------
You can view, comment on, or merge this pull request online at:
#99
Commit Summary
- Modified dummy_interface struct to add prefixlen along with Address
File Changes
- *M* vnet/unix/netlink.go
<https://github.com/platinasystems/go/pull/99/files#diff-0> (26)
Patch Links:
- https://github.com/platinasystems/go/pull/99.patch
- https://github.com/platinasystems/go/pull/99.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#99>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQZoCgyDaMN6pMCXBWod3e4ERqIAx6uks5tQWeggaJpZM4R1KtN>
.
|
I have created this pull request with the Fix for issue #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #30
After the fix following is the result when dummy interface is added:
@fszyang