Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try out fewer parens in ecto_ch #4769

Closed
wants to merge 3 commits into from
Closed

Try out fewer parens in ecto_ch #4769

wants to merge 3 commits into from

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Nov 4, 2024 •
edited
Loading

Opening this PR just to try out the excessive parens fix (plausible/ecto_ch#207) in preview env before making an ecto_ch release.

What queries were causing problems?

cc @macobo

@ruslandoga ruslandoga requested a review from macobo November 4, 2024 03:59
@ruslandoga ruslandoga added preview and removed preview labels Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Preview environment👷🏼‍♀️🏗️
PR-4769

@ruslandoga ruslandoga mentioned this pull request Nov 4, 2024
Merged
@plausible plausible deleted a comment from github-actions bot Nov 4, 2024
@ruslandoga ruslandoga changed the title try out fewer parens in ecto_ch Try out fewer parens in ecto_ch Nov 4, 2024
@macobo
Copy link
Contributor

macobo commented Nov 5, 2024 •
edited
Loading

Tested it out locally to see queries made in http://localhost:8000/api/stats/dummy.site/sources/?period=7d&date=2024-11-05&filters=%5B%5D&with_imported=true&comparison=previous_period&compare_from=undefined&compare_to=undefined&match_day_of_week=true&limit=9. The SQL output shows reduced nesting perfectly, thank you!

@ruslandoga
Copy link
Contributor Author

ruslandoga commented Nov 5, 2024 •
edited
Loading

@macobo thank you for trying it out! I'll open a PR with a new ecto_ch version next.

@ruslandoga ruslandoga closed this Nov 5, 2024
@ruslandoga ruslandoga deleted the fewer-parens branch November 5, 2024 07:19
@ruslandoga ruslandoga mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo Awaiting requested review from macobo

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslandoga @macobo