Average Scroll Depth Metric: handle missing data better #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macobo
reviewed
Dec 10, 2024
| @@ -0,0 +1,18 @@ | |||
| defmodule Plausible.DataMigration.MissingScrollDepth do | |||
There was a problem hiding this comment.
Q: Why is this a data migration not a normal one? Do we want to maintain it long-term?
There was a problem hiding this comment.
I just figured it's the preferred way of doing it since are no schema changes involved. When included in the normal migration pipeline, it would run every time when running migrations from scratch. Thought that would be unnecessary.
There was a problem hiding this comment.
Do we want to maintain it long-term?
Nope - we could also just run Plausible.DataMigration.MissingScrollDepth.run() in the remote shell and delete this file later on.
There was a problem hiding this comment.
Note we could also just run the same sql directly in clickhouse, but will leave it up to you.
macobo
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
UInt8) rather than 0 for pageleave eventsReasoning:
A scroll depth of 0 currently represents a missing value, but it can also be a valid scroll depth in case of extremely short viewports and long documents. Also, 0's are currently counted towards average which we don't want to do in case of missing values
Tests
Changelog
Documentation
Dark mode