Migration: Add scroll_depth to imported_pages #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apata
approved these changes
Dec 16, 2024
ukutaht
approved these changes
Dec 16, 2024
You're right - I just figured that rolling it back would not be necessary in any case. The column has a default value, and it's not in the schema yet, so there shouldn't by any issues. I'll also run it on staging first and complete a full export -> import flow. |
Famous last words... Why not add it: a6e92ff |
RobertJoonas
force-pushed
the
scroll-depth-imported-pages-migration
branch
from
b1057f4 to
7d27c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR only contains the migration adding the
scroll_depth UInt8column to theimported_pagesClickHouse table.The column will have a default value of 255 which hints that the value is non-existent (a valid scroll depth has to be from 0 to 100). The alternatives default values are:
When querying scroll depth from imported data, we'll simply filter out rows where
scroll_depthis more than 100.