Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average Scroll Depth Metric: another imported schema migration #4932

Merged

Conversation

RobertJoonas
Copy link
Contributor

Changes

When merging imported data into stats queries, we cannot simply divide scroll_depth / visitors to get the imported scroll depth. That’s wrong because visitors is based on pageviews, not pageleaves. Therefore, we’ll need to export an additional metric - pageleave_visitors which we can use specifically for that calculation.

Note: This field should also be used for our new time on page in the future

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@RobertJoonas RobertJoonas requested a review from a team December 31, 2024 12:14
@ukutaht
Copy link
Contributor

ukutaht commented Jan 2, 2025

Is this for importing data from another Plausible instance, GA4, or both?

@RobertJoonas
Copy link
Contributor Author

Is this for importing data from another Plausible instance, GA4, or both?

Only for importing from another Plausible instance.

@RobertJoonas RobertJoonas added this pull request to the merge queue Jan 2, 2025
Merged via the queue into master with commit c29b93f Jan 2, 2025
8 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2025
@RobertJoonas RobertJoonas deleted the scroll-depth-imported-pageleave-visitors-migration branch January 2, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants