Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker build + FE test #4933

Merged
merged 2 commits into from
Jan 2, 2025
+2 −3
Merged

Fix docker build + FE test #4933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5842eb4
fix docker build
RobertJoonas Dec 31, 2024
3b8cb2a
fix FE test
RobertJoonas Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ RUN mkdir /app
WORKDIR /app

# install build dependencies
RUN apk add --no-cache git nodejs yarn python3 npm ca-certificates wget gnupg make gcc libc-dev brotli && \
npm install npm@latest -g
RUN apk add --no-cache git nodejs yarn python3 npm ca-certificates wget gnupg make gcc libc-dev brotli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a hotfix, what you propose seems good!
However, I think best practice would be to build also in the container with the version we're using locally (as defined in .tool-versions and read in various worfklows using the version output by marocchino/tool-versions-action).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! In that case we'll need to install node from a source other than apk. I'll merge this one to unblock others and find a solution to use the node version from .tool-versions.


COPY mix.exs ./
COPY mix.lock ./
Expand Down
2 changes: 1 addition & 1 deletion assets/js/dashboard/query-dates.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ test.each([
test.each([
[
{ period: 'custom', from: '2024-08-10', to: '2024-08-20' },
'10 Aug - 20 Aug'
'10 Aug - 20 Aug 24'
],
[{ period: 'realtime' }, 'Realtime']
])(
Expand Down
Loading