-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hand-rolled dropdown on the dashboard and menu-related UI fixes #5037
Open
apata
wants to merge
23
commits into
saved-segments/singular-bar
Choose a base branch
from
saved-segments/replace-handrolled-dropdown
base: saved-segments/singular-bar
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replace hand-rolled dropdown on the dashboard and menu-related UI fixes #5037
apata
wants to merge
23
commits into
saved-segments/singular-bar
from
saved-segments/replace-handrolled-dropdown
+1,318
−1,171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apata
changed the title
Saved segments/replace handrolled dropdown
Replace hand-rolled dropdown on the dashboard and menu-related UI fixes
Jan 30, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes handrolled dropdowns and replaces them with headlessui Popovers: https://headlessui.com/v1/react/popover
Also tried to use headlessui Menu component for datepicker, but unfortunately those were too opinionated to work well with our keybinds.
Had to refactor the datepicker: visually that means extremely minor changes (first group doesn't have top padding)
Fixes the issue with calendars positioning off screen, aligning their right edge to right of dropdown or right of visible page on smaller screens.
Fixes issues with Dashboard modals not receiving focus
Fixes issues with Escape clearing filters instead of closing opened menu / popover
Fixes issues with multiple dropdowns being openable at the same time
Optimises top bar components re-rendering too many times for no reason
One little issue remains: the calendar doesn't close when navigating to other menus with the keyboard, nor does it capture focus or Escape, and close itself on Escape or Tab out. I tried various ways to render the calendars 1) in headlessui dialogs 2) in headlessui popovers etc, but wasn't able to get it working.
Tests
Changelog
Documentation
Dark mode