Modified to fix issue of delay b/w animation loop in not applying. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When animation is triggered by start animation, after triggering animation loop, it comes back to default animation, but delay specified was not being applied b/w animation loops. Conflicts: src/ui/SpriteView.js
|
This one's a bit tricky to merge right now. I think the API for SpriteView needs a lot of clean up in general. For example, the opts accepted into I'm planning either an API clean-up / optimization for this class or a new class if backwards incompatibility is an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose a SpriteView instance is created with default animation and delay and another animation is triggered by startAnimation function, when it comes back to default animation, delay specified was not being applied b/w animation loops.