Skip to content

Commit

Permalink
chore: upgrade flutter build version
Browse files Browse the repository at this point in the history
  • Loading branch information
KyoheiG3 committed Oct 6, 2024
1 parent 624f814 commit f44dd82
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/review.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Flutter
uses: subosito/flutter-action@v2
with:
flutter-version: 3.22.3
flutter-version: 3.24.3
cache: true

- name: Setup pub
Expand Down
11 changes: 5 additions & 6 deletions packages/playbook_generator/lib/src/playbook_builder.dart
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,14 @@ ${storiesLibrary.accept(emitter)}
if (element is ClassElement) {
return (element.unnamedConstructor?.isDefaultConstructor ?? false) &&
element.allSupertypes.any(
(s) => s.getDisplayString(withNullability: true) == w,
(s) => s.getDisplayString() == w,
);
} else if (element is FunctionElement) {
final firstParam = element.parameters.firstOrNull?.type
.getDisplayString(withNullability: false);
final firstParam =
element.parameters.firstOrNull?.type.getDisplayString();
return element.parameters.length <= 1 &&
(firstParam == null || firstParam == bc) &&
element.returnType.getDisplayString(withNullability: true) == w;
element.returnType.getDisplayString() == w;
} else {
return false;
}
Expand Down Expand Up @@ -135,8 +135,7 @@ ${a(refer(scenarioName, _playbookUrl))}(
.where((e) => e.isPublic && e.parameters.isEmpty)
.expand<Code>(
(e) {
final returnTypeString =
e.returnType.getDisplayString(withNullability: true);
final returnTypeString = e.returnType.getDisplayString();
final scenarioRefer = refer(e.displayName, uri);
if (returnTypeString == 'Scenario') {
return [scenarioRefer([]).code];
Expand Down

0 comments on commit f44dd82

Please sign in to comment.