Further performance adjustment

playbook-ui · Feb 14, 2024 · 40109a7 · 40109a7
1 parent bab6ae4
commit 40109a7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/Sources/PlaybookUI/Internal/Utilities/ImageLoader.swift b/Sources/PlaybookUI/Internal/Utilities/ImageLoader.swift
@@ -49,7 +49,6 @@ private extension ImageLoader {
         }
 
         guard !item.isCancelled else {
-            queue.removeFirst()
             return startNext()
         }
 
@@ -62,7 +61,6 @@ private extension ImageLoader {
             }
 
             guard !item.isCancelled else {
-                queue.removeFirst()
                 return startNext()
             }
 
@@ -93,7 +91,6 @@ private extension ImageLoader {
                 item.continuation?.resume(returning: image)
                 item.continuation = nil
                 imageCache.create(file: data, for: item.source)
-                queue.removeFirst()
                 startNext()
             }
         }
@@ -104,7 +101,8 @@ private extension ImageLoader {
             return
         }
 
-        if sequentiallyProcessedCount < 4 {
+        if sequentiallyProcessedCount < 3 {
+            queue.removeFirst()
             start()
         }
         else {
@@ -114,6 +112,7 @@ private extension ImageLoader {
                 }
 
                 sequentiallyProcessedCount = 0
+                queue.removeFirst()
                 start()
             }
         }

diff --git a/Sources/PlaybookUI/Internal/Views/GalleryKindRow.swift b/Sources/PlaybookUI/Internal/Views/GalleryKindRow.swift
@@ -23,7 +23,7 @@ internal struct GalleryKindRow: View {
             .padding(.horizontal, 24)
 
             ScrollView(.horizontal, showsIndicators: false) {
-                LazyHStack(alignment: .top, spacing: 0) {
+                LazyHStack(spacing: 8) {
                     ForEach(data.scenarios, id: \.scenario.name) { data in
                         Button {
                             onSelect(data)

diff --git a/Sources/PlaybookUI/Internal/Views/GalleryThumbnail.swift b/Sources/PlaybookUI/Internal/Views/GalleryThumbnail.swift
@@ -45,7 +45,7 @@ internal struct GalleryThumbnail: View {
         .onChange(of: colorScheme) { _ in
             image = nil
         }
-        .task(id: colorScheme) {
+        .task(id: colorScheme, priority: .background) {
             let source = ImageSource(
                 scenario: data.scenario,
                 kind: data.kind,