fix: Blank snapshot is generated if it exceeds the internal size limitation #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… limitation 8192x8192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
"Interestingly",
UIView.drawHierarchyseems to have an internal hard-coded limit size of 8192x8192, and specifying a size beyond that resulting in an empty image is drawn.It's reported in Apple's developer forums but there's no way properly address that issue.
So this PR adds a workaround that scales down the drawn image into a size that fits within the limitation once and then scales up to the expected size.
This may reduce the quality of the generated snapshots, but was not so critical when tested in the sample app.